Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong import path #5417

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix wrong import path #5417

merged 1 commit into from
Dec 10, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Dec 7, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7412b7) 87.59% compared to head (8d6d761) 87.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5417   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files         583      583           
  Lines       46389    46389           
  Branches     7018     7018           
=======================================
  Hits        40636    40636           
  Misses       5753     5753           
Flag Coverage Δ
unittests 87.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing
Copy link
Member

Why did the test runner not catch this error?

@mkslanc
Copy link
Contributor Author

mkslanc commented Dec 10, 2023

Why did the test runner not catch this error?

@nightwing this file has // @ts-nocheck flag at the beginning. Because it caused too many problems in type generation part. I noticed this one while documentation generation with typedoc (Seems it has not ignored this file by default)

@nightwing nightwing merged commit aac600d into ajaxorg:master Dec 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants