Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression with popup selectedNode and improve types #5426

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

nightwing
Copy link
Member

fixes #5420

also moves selectedNode from textLayer to popup to fix type annotations

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b303256) 87.59% compared to head (047f2ac) 87.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5426      +/-   ##
==========================================
- Coverage   87.59%   87.59%   -0.01%     
==========================================
  Files         584      584              
  Lines       46409    46408       -1     
  Branches     7021     7021              
==========================================
- Hits        40651    40650       -1     
  Misses       5758     5758              
Flag Coverage Δ
unittests 87.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 3c69933 into master Dec 14, 2023
3 checks passed
@nightwing nightwing deleted the fix-popup branch December 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

popup.js:在有滚动条的输入提示上,操作鼠标时(滚轮)会报错
2 participants