Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: generator function's determination and wrong parameter highlighting #5538

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Apr 23, 2024

Issue #, if available: #5257

Description of changes:
This should fix 2 out of 3 problems mentioned in #5257:

  1. Generator functions proper highlight
  2. Greedy pattern, which wrongly highlighted arguments in function calls

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (7869158) to head (170feb0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5538   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         593      593           
  Lines       42839    42842    +3     
  Branches     7120     7120           
=======================================
+ Hits        37117    37120    +3     
  Misses       5722     5722           
Flag Coverage Δ
unittests 86.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit ceca6f7 into ajaxorg:master Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants