Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: preventing directory traversal in dev server #5567

Merged
merged 2 commits into from
May 27, 2024

Conversation

marinsokol5
Copy link
Contributor

@marinsokol5 marinsokol5 commented May 27, 2024

Description of changes:

  • We normalize the URI and check if it's the same as before to account for any relative paths, such as . or ..

Discovered thanks to Jafar Akhoundali and Hamidreza Hamidi.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (1f166eb) to head (4b42204).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5567   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files         594      594           
  Lines       43017    43017           
  Branches     7129     7129           
=======================================
  Hits        37331    37331           
  Misses       5686     5686           
Flag Coverage Δ
unittests 86.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marinsokol5 marinsokol5 merged commit a3277ea into master May 27, 2024
3 checks passed
@marinsokol5 marinsokol5 deleted the directory-traversal-mitigation branch May 27, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants