Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hack in kitchen sink demo #5587

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Jun 11, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (a3277ea) to head (dff586f).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5587   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files         594      594           
  Lines       43017    43036   +19     
  Branches     7129     7133    +4     
=======================================
+ Hits        37331    37348   +17     
- Misses       5686     5688    +2     
Flag Coverage Δ
unittests 86.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@InspiredGuy
Copy link
Contributor

@mkslanc Gutter annotation doesn't show correct level of error in https://raw.githack.com/mkslanc/ace/fix-demo-linters/kitchen-sink.html
image

In https://ace.c9.io/build/kitchen-sink.html it shows correct gutter annotation
image

@mkslanc
Copy link
Contributor Author

mkslanc commented Jun 12, 2024

@mkslanc Gutter annotation doesn't show correct level of error in https://raw.githack.com/mkslanc/ace/fix-demo-linters/kitchen-sink.html image

In https://ace.c9.io/build/kitchen-sink.html it shows correct gutter annotation image

It looks like turned off Use Ace Linters option in your screenshot.
Option turned off:
image
Option turned on :
image

@InspiredGuy
Copy link
Contributor

@mkslanc it was turned on (you can see red underline under the text if you look closely), but somehow didn't work properly. When I check now it seems to work

@InspiredGuy InspiredGuy merged commit 06fd974 into ajaxorg:master Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants