Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typeerror in font metrics getZoom #5600

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: The type check in the build started failing recently:

Screenshot 2024-06-25 at 15 57 35

likely due to a new typescript version being used by the Github action. This change explicitly constructs a Number from
window.getComputedStyle(element)["zoom"] to prevent these type issues.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (16c95b3) to head (1a1e9fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5600   +/-   ##
=======================================
  Coverage   86.79%   86.79%           
=======================================
  Files         594      594           
  Lines       43091    43091           
  Branches     7147     7147           
=======================================
  Hits        37400    37400           
  Misses       5691     5691           
Flag Coverage Δ
unittests 86.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit 2591c36 into ajaxorg:master Jun 25, 2024
3 checks passed
@akoreman akoreman deleted the font_metric_fix branch June 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants