fix: ghost text rendering of empty lines #5615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NA
Description of changes: In the ghost text, we set the content of a line as the text content of a div. For lines without any text (e.g. when the suggestion has a line of white space) this results in a div without any contents, which most browsers will not render. This change sets a space as the text content if it's empty to ensure the empty lines get rendered.
Before this change:
Screen.Recording.2024-07-18.at.11.30.30.mov
After:
Screen.Recording.2024-07-18.at.11.29.58.mov
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: