Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ghost text rendering of empty lines #5615

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Jul 18, 2024

Issue #, if available: NA

Description of changes: In the ghost text, we set the content of a line as the text content of a div. For lines without any text (e.g. when the suggestion has a line of white space) this results in a div without any contents, which most browsers will not render. This change sets a space as the text content if it's empty to ensure the empty lines get rendered.

Before this change:

Screen.Recording.2024-07-18.at.11.30.30.mov

After:

Screen.Recording.2024-07-18.at.11.29.58.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (ed233cf) to head (b60cd72).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5615   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         594      594           
  Lines       43143    43151    +8     
  Branches     7150     7151    +1     
=======================================
+ Hits        37489    37497    +8     
  Misses       5654     5654           
Flag Coverage Δ
unittests 86.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit 1ae0bdc into ajaxorg:master Jul 18, 2024
3 checks passed
@akoreman akoreman deleted the ghost_text_new_lines branch July 18, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants