Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github theme. #799

Merged
merged 1 commit into from
Jun 14, 2012
Merged

Add github theme. #799

merged 1 commit into from
Jun 14, 2012

Conversation

bootstraponline
Copy link
Contributor

I created a new theme for Ace based on GitHub's pygments CSS for gollum's live preview feature.

@nightwing
Copy link
Member

looks nice,

can you add styles for selection and cursor (like in https://github.com/ajaxorg/ace/blob/master/lib/ace/theme/textmate.css) so that this is usable as an editor theme too
if no we probably should find a better place for static only themes. @fjakobs what do you think?

also to merge this we need we need a signed cla from you. Please see the last paragraph of the readme

@bootstraponline
Copy link
Contributor Author

I added selection and cursor styles from textmate.css. For the CLA is there an option to sign online like Google does? https://code.google.com/legal/individual-cla-v1.0.html

Add cursor and selection styles from textmate.css.
@fjakobs
Copy link
Contributor

fjakobs commented Jun 9, 2012

It look good for all files not just CSS. If that is the case I'm all for pulling it.

@bootstraponline
Copy link
Contributor Author

CLA sent. The theme should work for all Ace modes.

@bootstraponline
Copy link
Contributor Author

Is there anything else I should do to have this pulled?

nightwing added a commit that referenced this pull request Jun 14, 2012
@nightwing nightwing merged commit 5f6cbc8 into ajaxorg:master Jun 14, 2012
@nightwing
Copy link
Member

merged now, thanks!
sorry for the delay this time, since cla issues are solved merging next time will be lightning fast:)

@bootstraponline
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants