-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HomeFeedActivity. #19
Conversation
@Chromicle There was no progress bar to show whether the list is loading or not. So I'm adding that currently and after that, this branch is ready to be merged. Please review the code and give a suggestion. |
@Chromicle It's done, I've added the determinate progress bar. Please check the screen recording and screenshots. |
Can you just solve merge conflicts |
Yeah, sure. Give me 5 minutes. |
@Chromicle Synced with the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work but if we don't find the username or if the user did not appear for any contest we are getting blank screen so, just check the list that if the size of the list is equals to zero then make a text view that
"Did not appear any contests"
@@ -1,7 +1,7 @@ | |||
<resources> | |||
|
|||
<!-- Base application theme. --> | |||
<style name="AppTheme" parent="Theme.AppCompat.Light.DarkActionBar"> | |||
<style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you change this to no action bar
for the main activity it is good if there is no action bar but please add the Action bar to the home feed activity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 🎉
Description I've modified the MainActivity. So now in this activity user have to enter the preferred Handel in order to see the contest list. Upon submitting the handel new activity is opened displaying the contest list.
Issue link #3
ScreenRecording
https://drive.google.com/open?id=1E_NYoR81H0Y0BsLbe7wXlx5xEs5RR5QW
Screenshots