Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HomeFeedActivity. #19

Merged
merged 5 commits into from
Oct 6, 2019

Conversation

jaindiv26
Copy link
Contributor

@jaindiv26 jaindiv26 commented Oct 3, 2019

Description I've modified the MainActivity. So now in this activity user have to enter the preferred Handel in order to see the contest list. Upon submitting the handel new activity is opened displaying the contest list.

Issue link #3

ScreenRecording

https://drive.google.com/open?id=1E_NYoR81H0Y0BsLbe7wXlx5xEs5RR5QW

Screenshots

Screenshot_2019-10-03-23-47-15-551_com example android codeforces

Screenshot_2019-10-03-23-47-05-860_com example android codeforces

Screenshot_2019-10-03-23-47-03-139_com example android codeforces

@jaindiv26
Copy link
Contributor Author

@Chromicle There was no progress bar to show whether the list is loading or not. So I'm adding that currently and after that, this branch is ready to be merged. Please review the code and give a suggestion.

@jaindiv26
Copy link
Contributor Author

jaindiv26 commented Oct 3, 2019

@Chromicle It's done, I've added the determinate progress bar. Please check the screen recording and screenshots.

@ajay-prabhakar
Copy link
Owner

Can you just solve merge conflicts

@jaindiv26
Copy link
Contributor Author

Yeah, sure. Give me 5 minutes.

@jaindiv26
Copy link
Contributor Author

@Chromicle Synced with the master branch.

Copy link
Owner

@ajay-prabhakar ajay-prabhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work but if we don't find the username or if the user did not appear for any contest we are getting blank screen so, just check the list that if the size of the list is equals to zero then make a text view that
"Did not appear any contests"

@@ -1,7 +1,7 @@
<resources>

<!-- Base application theme. -->
<style name="AppTheme" parent="Theme.AppCompat.Light.DarkActionBar">
<style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
Copy link
Owner

@ajay-prabhakar ajay-prabhakar Oct 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you change this to no action bar
for the main activity it is good if there is no action bar but please add the Action bar to the home feed activity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@jaindiv26
Copy link
Contributor Author

@Chromicle I've added the Light action bar theme to HomeFeedActivity and displayed a toast when no contest was found.

Here's a screenshot of the changes I've made.

Screenshot_1570342281

Copy link
Owner

@ajay-prabhakar ajay-prabhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🎉

@ajay-prabhakar ajay-prabhakar merged commit a65b497 into ajay-prabhakar:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants