-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New installer options (v2) #672
Commits on Jan 23, 2024
-
Add support for options in install script
This adds support for serveral new command line options (taken from the usage): - `-b, --bin-dir Override the bin installation directory` - `-m, --man-dir Override the man installation directory` - `-a, --arch Override the architecture identified by the installer` - `-h, --help Display this help message` This also (coincidentally) allows for $BIN_DIR, $MAN_DIR, and $ARCH to be set to create default settings for these. These variables are *always* overwritten by the command line arguments.
Configuration menu - View commit details
-
Copy full SHA for 9dd4d40 - Browse repository at this point
Copy the full SHA 9dd4d40View commit details -
Configuration menu - View commit details
-
Copy full SHA for c01c75f - Browse repository at this point
Copy the full SHA c01c75fView commit details -
reset $sudo when writing man pages.
This helps ensure that mismatched permission on `_bin_dir` and `_man_dir` don't cause issues. Also prevents creating man pages owned by root being written to the user's $HOME
Configuration menu - View commit details
-
Copy full SHA for 8c8a0cf - Browse repository at this point
Copy the full SHA 8c8a0cfView commit details -
fix: test_writable should fail for empty paths
This prevents attempting to create files in `/` if a path is not given, instead failing early.
Configuration menu - View commit details
-
Copy full SHA for 1d875d3 - Browse repository at this point
Copy the full SHA 1d875d3View commit details -
change installation instructions
They now suggest passing to `sh`, rather than `bash`, to match the shebang and reduce posibility that non-posix behaivor of `bash` affects the script. this was requested by @ajeetdsouza
Configuration menu - View commit details
-
Copy full SHA for 871fe02 - Browse repository at this point
Copy the full SHA 871fe02View commit details -
add simple check to ensure that local is supported
Since the installation instructions now recommend using `sh`, check that this implementation *does* support local before continuing.
Configuration menu - View commit details
-
Copy full SHA for b69bcd5 - Browse repository at this point
Copy the full SHA b69bcd5View commit details -
Use end-of-options marker (--) when user input is passed to a command
This ensures that odd values for _bin_name, _bin_dir, and others aren't treated as options to the command and cause a failure.
Configuration menu - View commit details
-
Copy full SHA for efbd14a - Browse repository at this point
Copy the full SHA efbd14aView commit details -
fix unset variable _arch in usage
Remove the display of this default value, since we can't detect it without erroring before usage.
Configuration menu - View commit details
-
Copy full SHA for d4ad8c3 - Browse repository at this point
Copy the full SHA d4ad8c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b242e49 - Browse repository at this point
Copy the full SHA b242e49View commit details -
the ci requires that you run `shfmt -w --indent=4 --language-dialect=posix --simplify *.sh'`, and as such, i now have. note: I also formatted the case statement in parse_args to fit on one screen while still being readable.
Configuration menu - View commit details
-
Copy full SHA for 1730413 - Browse repository at this point
Copy the full SHA 1730413View commit details
Commits on May 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for da7a6b7 - Browse repository at this point
Copy the full SHA da7a6b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ac6f5a - Browse repository at this point
Copy the full SHA 3ac6f5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c7eedd - Browse repository at this point
Copy the full SHA 9c7eeddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0859427 - Browse repository at this point
Copy the full SHA 0859427View commit details