Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New installer options (v2) #672

Merged
merged 14 commits into from
May 5, 2024
Merged

Commits on Jan 23, 2024

  1. Add support for options in install script

    This adds support for serveral new command line options (taken from the usage):
        - `-b, --bin-dir   Override the bin installation directory`
        - `-m, --man-dir   Override the man installation directory`
        - `-a, --arch      Override the architecture identified by the installer`
        - `-h, --help      Display this help message`
    This also (coincidentally) allows for $BIN_DIR, $MAN_DIR, and $ARCH to be set to create default settings for these.
    These variables are *always* overwritten by the command line arguments.
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9dd4d40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c01c75f View commit details
    Browse the repository at this point in the history
  3. reset $sudo when writing man pages.

    This helps ensure that mismatched permission on `_bin_dir` and `_man_dir` don't cause issues.
    Also prevents creating man pages owned by root being written to the user's $HOME
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8c8a0cf View commit details
    Browse the repository at this point in the history
  4. fix: test_writable should fail for empty paths

    This prevents attempting to create files in `/` if a path is not given, instead failing early.
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1d875d3 View commit details
    Browse the repository at this point in the history
  5. change installation instructions

    They now suggest passing to `sh`, rather than `bash`, to match the shebang and reduce posibility that non-posix behaivor of `bash` affects the script.
    
    this was requested by @ajeetdsouza
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    871fe02 View commit details
    Browse the repository at this point in the history
  6. add simple check to ensure that local is supported

    Since the installation instructions now recommend using `sh`, check that this implementation *does* support local before continuing.
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b69bcd5 View commit details
    Browse the repository at this point in the history
  7. Use end-of-options marker (--) when user input is passed to a command

    This ensures that odd values for _bin_name, _bin_dir, and others aren't treated as options to the command and cause a failure.
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    efbd14a View commit details
    Browse the repository at this point in the history
  8. fix unset variable _arch in usage

    Remove the display of this default value, since we can't detect it without erroring before usage.
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d4ad8c3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b242e49 View commit details
    Browse the repository at this point in the history
  10. fix(ci): run shfmt

    the ci requires that you run `shfmt -w --indent=4 --language-dialect=posix --simplify *.sh'`, and as such, i now have.
    
    note: I also formatted the case statement in parse_args to fit on one screen while still being readable.
    aarondill committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1730413 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Configuration menu
    Copy the full SHA
    da7a6b7 View commit details
    Browse the repository at this point in the history
  2. try_sudo

    ajeetdsouza committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3ac6f5a View commit details
    Browse the repository at this point in the history
  3. remove local check

    ajeetdsouza committed May 5, 2024
    Configuration menu
    Copy the full SHA
    9c7eedd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0859427 View commit details
    Browse the repository at this point in the history