Add brightness #199
Closed
Add brightness #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add release tooling
Add jest
feat: typescript, linting
feat: update release process
# [0.13.0](v0.12.0...v0.13.0) (2020-11-21) ### Features * typescript, linting ([510644e](510644e)) * update release process ([eb21cf1](eb21cf1))
This moves all files to typescript, creates and deploys types, and makes a strip facotry instead of a base class, while retaining all original tests BREAKING CHANGE: strip class becomes a factory, private api changes
feat(core): move to ts completly, strip factory
# [1.0.0](v0.13.0...v1.0.0) (2020-11-22) ### Features * **core:** move to ts completly, strip factory ([fc6e016](fc6e016)) ### BREAKING CHANGES * **core:** strip class becomes a factory, private api changes
feat: pixel breakdown to match strip
# [1.1.0](v1.0.0...v1.1.0) (2020-11-22) ### Features * pixel breakdown to match strip ([137a623](137a623))
Fix interface info
You can specify a maximum value for channels as well as a separate gamma per channel for more control over LED output.
You can specify a maximum value for channels as well as a separate gamma per channel for more control over LED output.
make that shit fuego.
|
oops |
|
@ScreamZ it's because it fundamentally changes a lot of assumptions around the repo and makes a lot of shifts to type script which wasn't really intended. As such this went into a little dead end. Noirmally the way I adjust brightness on a standard RGB strip is simply apply a multiplier backwards on the values - eg divide by half etc. It's not perfect but that works. Alternatively, I drop the voltage on the strip a little as most RGB strips will happily run at 3.3v instead of 5 and so long as you supply >2.5v the logic circuit will work okay. If you want to cherry pick the brightness parts out and make a PR then that would be much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.