Skip to content
This repository has been archived by the owner on Dec 31, 2022. It is now read-only.

Commit

Permalink
Added support for custom configuration in nginx
Browse files Browse the repository at this point in the history
  • Loading branch information
Igor Rzegocki committed May 11, 2016
1 parent f24e742 commit 448019a
Show file tree
Hide file tree
Showing 8 changed files with 41 additions and 6 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ Currently only nginx is supported.
* If you wish to use custom generated DH primes, instead of common ones
(which is a very good practice), put the contents (not file name) of the
`dhparams.pem` file into this attribute. [Read more here.](https://weakdh.org/sysadmin.html)
* `app['webserver']['extra_config']`
* Raw nginx configuration, which will be inserted into `server` section of the
application for HTTP port.
* `app['webserver']['extra_config_ssl']`
* Raw nginx configuration, which will be inserted into `server` section of the
application for HTTPS port. If set to `true`, the `extra_config` will be copied.
* [`app['webserver']['keepalive_timeout']`](http://nginx.org/en/docs/http/ngx_http_core_module.html#keepalive_timeout)
* **Default**: `15`
* `app['webserver']['log_dir']`
Expand Down
2 changes: 2 additions & 0 deletions attributes/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@

default['defaults']['webserver']['adapter'] = 'nginx'
default['defaults']['webserver']['ssl_for_legacy_browsers'] = false
default['defaults']['webserver']['extra_config'] = ''
default['defaults']['webserver']['extra_config_ssl'] = ''

## nginx

Expand Down
7 changes: 5 additions & 2 deletions libraries/drivers_webserver_nginx.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,18 @@ class Nginx < Drivers::Webserver::Base
allowed_engines :nginx
output filter: [
:build_type, :client_body_timeout, :client_header_timeout, :client_max_body_size, :dhparams, :keepalive_timeout,
:log_dir, :proxy_read_timeout, :proxy_send_timeout, :send_timeout, :ssl_for_legacy_browsers
:log_dir, :proxy_read_timeout, :proxy_send_timeout, :send_timeout, :ssl_for_legacy_browsers,
:extra_config, :extra_config_ssl
]
notifies :deploy, action: :reload, resource: 'service[nginx]', timer: :delayed
notifies :undeploy, action: :reload, resource: 'service[nginx]', timer: :delayed

def raw_out
node['defaults']['webserver'].merge(node['nginx']).merge(
output = node['defaults']['webserver'].merge(node['nginx']).merge(
node['deploy'][app['shortname']]['webserver'] || {}
).symbolize_keys
output[:extra_config_ssl] = output[:extra_config] if output[:extra_config_ssl] == true
output
end

def setup(context)
Expand Down
2 changes: 1 addition & 1 deletion metadata.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
license 'MIT'
description 'Set of chef recipes for OpsWorks based Ruby projects'
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version '0.2.0'
version '0.2.1'

depends 'build-essential', '~> 2.0'
depends 'deployer'
Expand Down
6 changes: 4 additions & 2 deletions spec/fixtures/node.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ def node(override = {})
webserver: {
adapter: 'nginx',
client_max_body_size: '125m',
dhparams: '--- DH PARAMS ---'
dhparams: '--- DH PARAMS ---',
extra_config: 'extra_config {}'
},
framework: {
adapter: 'rails',
Expand Down Expand Up @@ -74,7 +75,8 @@ def node(override = {})
},
webserver: {
adapter: 'nginx',
keepalive_timeout: '15'
keepalive_timeout: '15',
extra_config_ssl: 'extra_config_ssl {}'
},
framework: {
adapter: 'rails',
Expand Down
14 changes: 13 additions & 1 deletion spec/unit/libraries/drivers_webserver_nginx_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,19 @@
client_max_body_size: '125m',
client_body_timeout: '30',
dhparams: '--- DH PARAMS ---',
keepalive_timeout: '15'
keepalive_timeout: '15',
extra_config: 'extra_config {}',
extra_config_ssl: 'extra_config_ssl {}'
)
end

it 'copies extra_config to extra_config_ssl if extra_config_ssl is set to true' do
expect(described_class.new(aws_opsworks_app, node(defaults: { webserver: { extra_config_ssl: true } })).out).to eq(
client_max_body_size: '125m',
client_body_timeout: '30',
dhparams: '--- DH PARAMS ---',
extra_config: 'extra_config {}',
extra_config_ssl: 'extra_config {}'
)
end
end
6 changes: 6 additions & 0 deletions spec/unit/recipes/configure_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,12 @@
expect(chef_run)
.not_to render_file("/etc/nginx/sites-available/#{aws_opsworks_app['shortname']}")
.with_content('ssl_session_tickets off;')
expect(chef_run)
.to render_file("/etc/nginx/sites-available/#{aws_opsworks_app['shortname']}")
.with_content('extra_config {}')
expect(chef_run)
.not_to render_file("/etc/nginx/sites-available/#{aws_opsworks_app['shortname']}")
.with_content('extra_config_ssl {}')
expect(chef_run).to create_link("/etc/nginx/sites-enabled/#{aws_opsworks_app['shortname']}")
end

Expand Down
4 changes: 4 additions & 0 deletions templates/default/unicorn.nginx.conf.erb
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ server {
deny all;
}

<%= @out[:extra_config] %>

error_page 500 502 503 504 /500.html;
location = /500.html {
root <%= File.join(@deploy_dir, 'public') %>;
Expand Down Expand Up @@ -131,6 +133,8 @@ server {
}
}

<%= @out[:extra_config_ssl] %>

error_page 500 502 503 504 /500.html;
location = /500.html {
root <%= File.join(@deploy_dir, 'public') %>;
Expand Down

0 comments on commit 448019a

Please sign in to comment.