Enable configuration of PORT and SSL_PORT #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our use-case, we need to be able to listen on port 8080 instead of 9000. This change enables that while leaving default behavior almost completely unchanged.
docker run -p 9000:9000...
will continue to work unchangeddocker run -P
to automatically map container ports to random host ports will need to add--expose=9000 --expose=9443
to their command to maintain the same behavior.If we were running entirely in docker, we could have done this with
-p 8080:9000
but our environment actually unpacks the docker image and repacks it in another buildpack, so we can't use the-p
flag and instead have to rely on$PORT