Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable text selection in iOS (touch devices) #166

Closed
2 tasks done
aptonline opened this issue May 28, 2022 · 5 comments
Closed
2 tasks done

Disable text selection in iOS (touch devices) #166

aptonline opened this issue May 28, 2022 · 5 comments
Labels
✨ Feature A feature you'd like to be added

Comments

@aptonline
Copy link

aptonline commented May 28, 2022

Description

As you have implemented reordering tiles by long clicking on a tile this fails under iOS as long pressing a tile engages iOS’s text/image selection:
048E9979-10C6-4EBD-A1A3-15FEC9B4CF44
By disabling this for iOS (and other touch screen devices) you might be able to rearrange tiles as expected.

The following css may be all that is needed:

-webkit-user-select: none; /* Chrome all / Safari all */

Priority

Low (Nice-to-have)

Please tick the boxes

@aptonline aptonline added the ✨ Feature A feature you'd like to be added label May 28, 2022
@mariushosting
Copy link

+1

@ajnart ajnart added the 3️⃣ label Jun 4, 2022
ajnart added a commit that referenced this issue Jun 6, 2022
Fixed Disable text selection in iOS (touch devices) #166
@ajnart
Copy link
Owner

ajnart commented Jun 6, 2022

Fixed with 2594a7c

@ajnart ajnart closed this as completed Jun 6, 2022
@aptonline
Copy link
Author

aptonline commented Jun 10, 2022

While the text selection is fixed in 0.6.5 dev image allowing tiles to be rearranged you have to specifically select an area of the tile that doesn’t include an image or a link otherwise iOS engages the image or link preview. See the video below.

hommer.ios.issues.mov

Also note that selecting the menus or settings is very hit and miss in iOS and sometimes take a while to trigger. The burger menu however seems to open consistently on the first attempt.

@mikniche
Copy link

mikniche commented Jun 18, 2022

I'm having the same issue - let me know if you need any input to help fix it

@aptonline
Copy link
Author

Issues should ideally be left open until confirmed working as expected otherwise additional comments can be missed.

@aptonline aptonline mentioned this issue Jun 20, 2022
3 tasks
jonjon1123 pushed a commit to jonjon1123/homarr that referenced this issue Nov 5, 2022
Fixed Disable text selection in iOS (touch devices) ajnart#166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature A feature you'd like to be added
Projects
None yet
Development

No branches or pull requests

4 participants