Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Timeout #2002

Merged
merged 1 commit into from
Apr 18, 2024
Merged

OIDC Timeout #2002

merged 1 commit into from
Apr 18, 2024

Conversation

catrielmuller
Copy link
Contributor

@catrielmuller catrielmuller commented Apr 9, 2024

Hi Tomas (@ajnart), I have exactly the same issue reported on #1995 , this is a simple fix that can resolve a lot of headaches to the users that want to use OIDC (Because everything can be configured correctly, however if the latency between the service it's not enough will be fail)

Category

Bugfix

Overview

if the OIDC provider don't respond in less than 3500ms (Default NextAuth Implementation) the connection fails between Hommar backend and the OIDC provider.

This PR add a new config parameter to increase the timeout using AUTH_OIDC_TIMEOUT

Issue Number 1995

#1995

New Vars (if applicable)

  • Added AUTH_OIDC_TIMEOUT env variable keeping the same structure as the rest of AUTH_OIDC_XXXX Configs
  • I added 4 files related to DevEnv (https://devenv.sh/) to support nix.

Screenshot (if applicable)

No Applicable

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋. Thank you for making your first contribution to Homarr. Please ensure that you've completed all the points in the TODO checklist. We'll review your changes shortly.

Copy link
Owner

@ajnart ajnart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR ! I agree with the changes but please delete your dev/env files first !

Would you mind linking this PR to one in the docs repository to document this new env variable ?

.envrc Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to commit this fire?

.gitignore Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, no need to commit

@catrielmuller
Copy link
Contributor Author

@ajnart I will make that changes this night and only add the changes from this commit -> e19f53f

@catrielmuller
Copy link
Contributor Author

@ajnart I clean up this PR and I make another one (homarr-labs/documentation#65) to update the documentation.
If you need more help here, we can discuss if at least I can exclude that files on the .gitignore. DevEnv (https://devenv.sh/) it's a really cool way to define reproducible dev environments and it's super useful if anybody pull the project can have a required environment in 5 minutes.

Copy link
Owner

@ajnart ajnart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ajnart
Copy link
Owner

ajnart commented Apr 18, 2024

@ajnart I clean up this PR and I make another one (homarr-labs/documentation#65) to update the documentation. If you need more help here, we can discuss if at least I can exclude that files on the .gitignore. DevEnv (https://devenv.sh/) it's a really cool way to define reproducible dev environments and it's super useful if anybody pull the project can have a required environment in 5 minutes.

I think it's a great idea, but I don't know if many people will use it. You can do a POC PR and we can discuss it there. I'll look at the docs PR now ;)

@ajnart ajnart merged commit 53d1a57 into ajnart:dev Apr 18, 2024
2 checks passed
truecharts-admin referenced this pull request in truecharts/public May 8, 2024
…c270b55 by renovate (#21754)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/ajnart/homarr](https://togithub.com/ajnart/homarr) | patch |
`0.15.2` -> `0.15.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ajnart/homarr (ghcr.io/ajnart/homarr)</summary>

### [`v0.15.3`](https://togithub.com/ajnart/homarr/releases/tag/v0.15.3)

[Compare
Source](https://togithub.com/ajnart/homarr/compare/v0.15.2...v0.15.3)

> \[!NOTE]\
> We've been working actively on working torwards version 1.0 which will
include many improvements to performance, security and the overall look
& feel of Homarr. It will greatly overhaul the technical architecture of
Homarr. This work is done by volunteers. Please consider supporting our
work via donations at https://opencollective.com/homarr

#### Support for generic Home Assistant switches (lights, fans, ...)

Want to toggle your kitchen lights or shut off the music? Using the
brand new support for generic switches you can toggle now almost
anything:

![homeassistant-lights](https://togithub.com/ajnart/homarr/assets/30572287/2cd79222-ca7d-4773-95e8-845cb382468c)

#### Promox integration

Homarr now features a Promox widget that can display CPU, RAM and more
information directly on your dashboard:

![305290159-b6ed7b8a-335b-41d0-b5c8-8edb736db3ee](https://togithub.com/ajnart/homarr/assets/30572287/cfc6f949-16f8-4add-a4eb-668c258c3305)

#### Tdarr widget

Homarr now also integrates with Tdarr to display the status of your
workers and the queue:

![Untitled](https://togithub.com/ajnart/homarr/assets/30572287/b368c4ae-7b6e-42d7-9bfc-58a110646dbe)

#### Add placeholder for dynamic URLs

When using advanced reverse proxy setups, sometimes the hostname is not
known yet.
We have added a new feature that enables you to replace certain
placeholders: <img width="598"
alt="326171056-a55c3e49-9cd6-4523-90cf-16e91b2c7502"
src="https://github.com/ajnart/homarr/assets/30572287/53cf7469-586a-4fda-9dbf-3651cf3e2189">

#### Usability improvements to the torrent widget

The torrent widget has received a major upgrade and should scale now
better on most devices with improved customizability:


![image](https://togithub.com/ajnart/homarr/assets/30572287/8dbcd786-03ed-49da-b4ef-8a7b5b5bdd46)

![image](https://togithub.com/ajnart/homarr/assets/26098587/325ec664-c0cc-4cfa-bfb5-717d3674bda4)

#### Other bugfixes

-   Fixed overlapping of the grid elements and the navbar
-   Fixed video playback for iOS and Apple devices
- Fixed issues with the certificates for the avatars (this will also
resolve issues with the page being shown as "not secure")

#### What's Changed

- fix: health monitoring hotfix by
[@&#8203;hillaliy](https://togithub.com/hillaliy) in
[https://github.com/ajnart/homarr/pull/1970](https://togithub.com/ajnart/homarr/pull/1970)
- fix: change media request TV poster and movie name by
[@&#8203;SeDemal](https://togithub.com/SeDemal) in
[https://github.com/ajnart/homarr/pull/1983](https://togithub.com/ajnart/homarr/pull/1983)
- fix: weather widget does not refresh automatically by
[@&#8203;hillaliy](https://togithub.com/hillaliy) in
[https://github.com/ajnart/homarr/pull/1981](https://togithub.com/ajnart/homarr/pull/1981)
- fix: [#&#8203;1976](https://togithub.com/ajnart/homarr/issues/1976)
lower debounce time by
[@&#8203;manuel-rw](https://togithub.com/manuel-rw) in
[https://github.com/ajnart/homarr/pull/1979](https://togithub.com/ajnart/homarr/pull/1979)
- chore: new Crowdin updates by
[@&#8203;ajnart](https://togithub.com/ajnart) in
[https://github.com/ajnart/homarr/pull/1968](https://togithub.com/ajnart/homarr/pull/1968)
- feat: add Proxmox integration/widget by
[@&#8203;dslatt](https://togithub.com/dslatt) in
[https://github.com/ajnart/homarr/pull/1903](https://togithub.com/ajnart/homarr/pull/1903)
- feat: columns customize by
[@&#8203;hillaliy](https://togithub.com/hillaliy) in
[https://github.com/ajnart/homarr/pull/1975](https://togithub.com/ajnart/homarr/pull/1975)
- feat: added playsInline to VideoBackground by
[@&#8203;spkesDE](https://togithub.com/spkesDE) in
[https://github.com/ajnart/homarr/pull/1996](https://togithub.com/ajnart/homarr/pull/1996)
- fix: ping indicators floating above header in board customization page
by [@&#8203;krishnamuppaneni](https://togithub.com/krishnamuppaneni) in
[https://github.com/ajnart/homarr/pull/1998](https://togithub.com/ajnart/homarr/pull/1998)
- fix: OIDC Timeout by
[@&#8203;catrielmuller](https://togithub.com/catrielmuller) in
[https://github.com/ajnart/homarr/pull/2002](https://togithub.com/ajnart/homarr/pull/2002)
- fix: Pass axios error into log call for proxmox. Please include in
v0.15.3 by [@&#8203;dslatt](https://togithub.com/dslatt) in
[https://github.com/ajnart/homarr/pull/2012](https://togithub.com/ajnart/homarr/pull/2012)
- feat: add romanian language support by
[@&#8203;Meierschlumpf](https://togithub.com/Meierschlumpf) in
[https://github.com/ajnart/homarr/pull/2017](https://togithub.com/ajnart/homarr/pull/2017)
- fix: missing romanian language in next-i18next.config.js by
[@&#8203;Meierschlumpf](https://togithub.com/Meierschlumpf) in
[https://github.com/ajnart/homarr/pull/2018](https://togithub.com/ajnart/homarr/pull/2018)
- feat: add Tdarr integration and widget by
[@&#8203;jbruell](https://togithub.com/jbruell) in
[https://github.com/ajnart/homarr/pull/1882](https://togithub.com/ajnart/homarr/pull/1882)
- feat: torrent widget: polishing UI and improve popover interactions by
[@&#8203;SeDemal](https://togithub.com/SeDemal) in
[https://github.com/ajnart/homarr/pull/2016](https://togithub.com/ajnart/homarr/pull/2016)
- fix: Modals titles nested headers and edit mode nested buttons errors
by [@&#8203;SeDemal](https://togithub.com/SeDemal) in
[https://github.com/ajnart/homarr/pull/2019](https://togithub.com/ajnart/homarr/pull/2019)
- fix: Avatar host by [@&#8203;SeDemal](https://togithub.com/SeDemal) in
[https://github.com/ajnart/homarr/pull/2027](https://togithub.com/ajnart/homarr/pull/2027)
- feat: Home Assistant entity generic toggle by
[@&#8203;tuggan](https://togithub.com/tuggan) in
[https://github.com/ajnart/homarr/pull/2015](https://togithub.com/ajnart/homarr/pull/2015)
- feat: add logout callback URL and session expiration environment
variables by [@&#8203;SeDemal](https://togithub.com/SeDemal) in
[https://github.com/ajnart/homarr/pull/2023](https://togithub.com/ajnart/homarr/pull/2023)
- fix: ldap filters by [@&#8203;SeDemal](https://togithub.com/SeDemal)
in
[https://github.com/ajnart/homarr/pull/2033](https://togithub.com/ajnart/homarr/pull/2033)
- chore: new Crowdin updates by
[@&#8203;ajnart](https://togithub.com/ajnart) in
[https://github.com/ajnart/homarr/pull/1984](https://togithub.com/ajnart/homarr/pull/1984)
- feat: add `[homarr_base]` replacement for external urls by
[@&#8203;j3lte](https://togithub.com/j3lte) in
[https://github.com/ajnart/homarr/pull/2024](https://togithub.com/ajnart/homarr/pull/2024)
- core: increase version to 0.15.3 by
[@&#8203;Meierschlumpf](https://togithub.com/Meierschlumpf) in
[https://github.com/ajnart/homarr/pull/2007](https://togithub.com/ajnart/homarr/pull/2007)

#### New Contributors

- [@&#8203;dslatt](https://togithub.com/dslatt) made their first
contribution in
[https://github.com/ajnart/homarr/pull/1903](https://togithub.com/ajnart/homarr/pull/1903)
- [@&#8203;krishnamuppaneni](https://togithub.com/krishnamuppaneni) made
their first contribution in
[https://github.com/ajnart/homarr/pull/1998](https://togithub.com/ajnart/homarr/pull/1998)
- [@&#8203;catrielmuller](https://togithub.com/catrielmuller) made their
first contribution in
[https://github.com/ajnart/homarr/pull/2002](https://togithub.com/ajnart/homarr/pull/2002)
- [@&#8203;jbruell](https://togithub.com/jbruell) made their first
contribution in
[https://github.com/ajnart/homarr/pull/1882](https://togithub.com/ajnart/homarr/pull/1882)
- [@&#8203;j3lte](https://togithub.com/j3lte) made their first
contribution in
[https://github.com/ajnart/homarr/pull/2024](https://togithub.com/ajnart/homarr/pull/2024)

**Full Changelog**:
ajnart/homarr@v0.15.2...v0.15.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDkuMyIsInVwZGF0ZWRJblZlciI6IjM3LjM0OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants