Add JTDDataType to compile signature #1547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#1489
What changes did you make?
ref
for JTDDataType had to be changed. I don't entirely understand why, but my guess is that infer steps allow the compiler to "take a break" and so this helps with the recursion checking.SomeJTDSchemaType
. This is necessary to prevent typescript from inferring a JTDDataType when actually it's a different schema. This is especially a problem for simple types, e.g. the empty schema is valid JTD so it can confuse things.Is there anything that requires more attention while reviewing?
compile<never, ActualType>(...)
.{}
, there's a note linking to the issue that discusses how this is the one instance when this is actually what you want, and it's tested.