Add flag for persistant interval #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajvb
requested changes
Oct 23, 2016
| @@ -147,7 +152,7 @@ func main() { | |||
|
|
|||
| // Create cache | |||
| cache := job.NewMemoryJobCache(db) | |||
| cache.Start(DefaultPersistEvery) | |||
| cache.Start(time.Duration(c.Int("persist-every")) * time.Second) | |||
There was a problem hiding this comment.
Let's use the built-in duration string parsing - https://golang.org/pkg/time/#ParseDuration
This allows for 4h instead of 14400
Would also mean making it a StringFlag with a default of 5m.
Lastly lets remove the DefaultPersistEvery = 5 * time.Second at the top of this file.
elimisteve
reviewed
Oct 23, 2016
| duration, err := time.ParseDuration(c.String("persist-every")) | ||
| // if duration string could not be parsed, set duration to default | ||
| if err != nil { | ||
| cache.Start(time.Duration(5 * time.Minute)) |
There was a problem hiding this comment.
This silently fails to parse what the user specified and does something else instead. Not sure what @ajvb thinks should happen here, but hiding the error doesn't seem like the right way to go.
There was a problem hiding this comment.
I think we have two options:
- Let the program crash if the duration string could not be parsed and show an error.
- Show a message that the duration string could not be parsed and that the persistant interval was set to the default value.
|
Hey @rotespferd, thank you so much for the PR. I decided to go with #133 as a starting place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag as described in #131