Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS for mysql #211

Merged
merged 6 commits into from
May 26, 2020
Merged

TLS for mysql #211

merged 6 commits into from
May 26, 2020

Conversation

up9cloud
Copy link
Contributor

@up9cloud up9cloud commented May 6, 2020

No description provided.

@tooolbox
Copy link
Collaborator

tooolbox commented May 6, 2020

Looks good, thanks!

Unfortunately looks like one of the tests still has a race condition. #205 is the ultimate solution but I don't think I will get to it soon. I will try to put in a temporary fix and then you'll need to adjust your pull request to include the patch so your checks pass, otherwise I can't merge.

This was referenced May 23, 2020
Closed
Merged
@tooolbox
Copy link
Collaborator 

=== RUN   TestIntegrationTest
--- FAIL: TestIntegrationTest (0.01s)
    integration_test.go:53: Post http://127.0.0.1:46357/api/v1/job/: dial tcp 127.0.0.1:46357: connect: connection refused
FAIL

How bizarre, given that it just worked for several other commits.

@tooolbox tooolbox mentioned this pull request May 26, 2020
Merged
@tooolbox tooolbox merged commit 437f040 into ajvb:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@up9cloud @tooolbox