Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeClimate Configuration #42

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Add CodeClimate Configuration #42

merged 1 commit into from
Aug 2, 2019

Conversation

akabiru
Copy link
Owner

@akabiru akabiru commented Aug 1, 2019

Closes #30

@akabiru akabiru added the chores label Aug 1, 2019
@akabiru akabiru self-assigned this Aug 1, 2019
@akabiru
Copy link
Owner Author

akabiru commented Aug 1, 2019 •
edited
Loading

@vbrazo please enable Codeclimate for this Org/repo. https://codeclimate.com/dashboard

bpleslie
bpleslie approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@bpleslie bpleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@akabiru akabiru merged commit 3e09726 into akabiru:master Aug 2, 2019
@akabiru akabiru deleted the chore/add-codeclimate branch August 2, 2019 00:49
@akabiru
Copy link
Owner Author

akabiru commented Aug 6, 2019

@vbrazo please enable Codeclimate for this Org/repo. https://codeclimate.com/dashboard

@vbrazo any update on this one? 🙂

@vbrazo
Copy link
Collaborator

vbrazo commented Aug 7, 2019

Yes, I did. I get this error message when building the repository:

Screen Shot 2019-08-06 at 5 13 40 PM

@akabiru
Copy link
Owner Author

akabiru commented Aug 7, 2019

Oh, thanks! Brakeman is actually rails specific, so we can remove it. https://github.com/presidentbeef/brakeman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpleslie bpleslie bpleslie approved these changes

Assignees

@akabiru akabiru

Labels
chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate FakerBot CI & QA integrations
3 participants
@akabiru @vbrazo @bpleslie