Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to use equals from the cli #68

Merged
merged 4 commits into from
May 25, 2020

Conversation

jhughes1153
Copy link
Contributor

No description provided.

@PeterlitsZo
Copy link
Contributor

PeterlitsZo commented May 18, 2020

Hi, jhughes,
Do you think --flag="some thing" is a better idea? (If it is a String flag)
Oh! what will happen if I access it with command --string-flag "this"? Will the value of that argument be "this" but not this? It is really?
Peterlits Zo

@jhughes1153
Copy link
Contributor Author

Hi, jhughes,
Do you think --flag="some thing" is a better idea? (If it is a String flag)
Oh! what will happen if I access it with command --string-flag "this"? Will the value of that argument be "this" but not this? It is really?
Peterlits Zo

Hi, jhughes,
Do you think --flag="some thing" is a better idea? (If it is a String flag)
Oh! what will happen if I access it with command --string-flag "this"? Will the value of that argument be "this" but not this? It is really?
Peterlits Zo

I believe this works with --flag="some string with spaces" and if you want to to have the string in the program be "some string with spaces" you pass in --flag=""some string with spaces"". Usually if you need to pass in some value from the cli with spaces you would use quotes, thats a very common linux practice.

@akamensky
Copy link
Owner

@jhughes1153 many thanks, that is a great addition to this library to make it more compatible with CLI standards.

Can you please add tests covering cases when equals used for types other than string (your tests currently only cover string arguments.

For simplicity you can modify existing tests for other types by adding additional validations there.

@PeterlitsZo
Copy link
Contributor

Hi, @jhughes1153 ,
I get it! I do know less than I think...
Thanks for your reply.

@jhughes1153
Copy link
Contributor Author

@jhughes1153 many thanks, that is a great addition to this library to make it more compatible with CLI standards.

Can you please add tests covering cases when equals used for types other than string (your tests currently only cover string arguments.

For simplicity you can modify existing tests for other types by adding additional validations there.

Yeah, I added a few more types but not all, do you want full coverage for every type or are the types that I added fine?

@akamensky
Copy link
Owner

Thanks. LGTM.

@akamensky akamensky merged commit 7061ca3 into akamensky:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants