All previous updates, plus updated BarConn to return numpy array #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Info, reverted mkt_tm potentially obsolete bug fix
…s until merge is complete
erickmiller
changed the title
…rmittent bug fix for mkt_tm issue (line 455) this bug keeps happening intermittently causing an exception, appears to come from dtn and dont think it would have an effect on live trading since it's a conn_stats attribute
|
Closing this pull request as it is obsolete and superseded by the latest pull request: #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated pull request with all new features plus a feature/bug fix for the following issue: #11
Also contains the following updates from the last pull request:
Added more PEP8 fixes to conn.py, now when running
pylint --confidence=HIGH -E -s y conn.pyThe pylint analysis results in:
Also includes the previously requested fixes from prior pull request:
*PEP compliance (ran static checking and fixing with pylint and autopep)
*Refactored DerivConn into BarConn
*Removed DerivativeInfo from library
*Reverted mkt_tm potentially obsolete bug fix
Again for the manual merge, still not sure where the conflict is but it shouldn't be logical.