-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[akash-provider] do not issue TX when not needed #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test run resultRan helm upgrade from the local branch:
Bounce the akash-provider since it isn't happening automatically when the template changes but no the values passed via
Wait... and then check the logs:
|
Changes: - bump akash-provider chart to 0.153.0 - install bc - check Akash RPC node is not 30 seconds behind/ahead before continuing - do not append provider.yaml but rather create it from scratch - figure the provider address in case the user passes `--from=<key_name>` instead of `--from=<akash1...>` address - check provider existence on the blockchain before attempting to create a new one (`akash tx provider create provider.yaml ...`) - check whether provider settings (host uri, attributes, ...) have changed before broadcasting the new ones on the blockchain (`akash tx provider update provider.yaml ...`) - before generating and broadcasting the new provider certificate - check the last provider certificate found on the blockchain is valid - check whether the last provider certificate serial number found on the blockchain matches the local one Issues addressed: - fixes akash-network#35 - fixes akash-network#9
sacreman
approved these changes
May 8, 2022
tvanes
pushed a commit
to hoolia/akash-helm-charts
that referenced
this pull request
Jun 24, 2022
Changes: - bump akash-provider chart to 0.153.0 - install bc - check Akash RPC node is not 30 seconds behind/ahead before continuing - do not append provider.yaml but rather create it from scratch - figure the provider address in case the user passes `--from=<key_name>` instead of `--from=<akash1...>` address - check provider existence on the blockchain before attempting to create a new one (`akash tx provider create provider.yaml ...`) - check whether provider settings (host uri, attributes, ...) have changed before broadcasting the new ones on the blockchain (`akash tx provider update provider.yaml ...`) - before generating and broadcasting the new provider certificate - check the last provider certificate found on the blockchain is valid - check whether the last provider certificate serial number found on the blockchain matches the local one Issues addressed: - fixes akash-network#35 - fixes akash-network#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--from=<key_name>
instead of--from=<akash1...>
addressa new one (
akash tx provider create provider.yaml ...
)before broadcasting the new ones on the blockchain (
akash tx provider update provider.yaml ...
)matches the local one
Issues addressed: