Skip to content

Commit

Permalink
# [LOW] Wrong email recipient when replying to guest user comment
Browse files Browse the repository at this point in the history
Closes gh-271
  • Loading branch information
nikosdion committed Mar 30, 2023
1 parent 3e648ff commit b72428f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .idea/php.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php die(); ?>
Akeeba Engage 3.2.6
================================================================================
# [LOW] Wrong email recipient when replying to guest user comment (gh-271)
# [HIGH] The DataCompliance plugin crashed when viewing the data options for a user

Akeeba Engage 3.2.5
Expand Down
2 changes: 1 addition & 1 deletion component/backend/src/Helper/TemplateEmails.php
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ public static function sendMail(string $key, array $data, User $user = null, str
}

//if ($user->guest || $user->block || !$user->sendEmail)
if ($user->guest || $user->block)
if ($user->block)
{
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/engage/email/src/Extension/Email.php
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ protected function sendEmailMessages(string $type, CommentTable $comment, array
// Get the recipient Joomla user
try
{
$recipient = UserFetcher::getUser($userIDs[$email]);
$recipient = isset($userIDs[$email]) ? UserFetcher::getUser($userIDs[$email]) : null;
}
catch (Exception $e)
{
Expand Down

0 comments on commit b72428f

Please sign in to comment.