Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequireJS Config Building fails #1191

Closed
Schwierig opened this issue Jun 25, 2014 · 2 comments
Closed

RequireJS Config Building fails #1191

Schwierig opened this issue Jun 25, 2014 · 2 comments

Comments

@Schwierig
Copy link
Contributor

When require JS is running its generateMainConfig function (Oro\Bundle\RequireJSBundle\Provider\Config.php:83) the PimEnrich Bundle and the OroSegmentationTree Bundle are both using the same parameter key, which results in an exception being thrown due to an array being handed into the substr function.

Pim/Bundle/EnrichBundle/Resources/config/requirejs.yml
jstree/jquery.jstree.tree_selector: pimenrich/js/lib/jstree/jquery.jstree.tree_selector

Oro/Bundle/SegmentationTreeBundle/Resources/config/requirejs.yml
'jstree/jquery.jstree.tree_selector': 'bundles/orosegmentationtree/lib/jstree/jquery.jstree.tree_selector.js'

I'm not sure if it is the right fix would be to remove the config path from the EnrichBundle or if the dependencies don't allow us to do that.

I'm using the latest dev-master version

@filips-alpe
Copy link
Contributor

Hi!
This is indeed the case when the keys used are identical, that doesn't work. The real reason for this is completely different though, the OroSegmentationTreeBundle has been removed so we moved this to the Pim and preserved the same key. You'll need to run composer.phar update - at that point the OroSegmentationTreeBundle shouldn't be there anymore.

@Schwierig
Copy link
Contributor Author

It seems I used the community-standard version of the composer.json instead of the dev version. Though the composer update didn't remove the bundle at all.
I guess there where some incompability issues with the parameter files, thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants