Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I add runner libraries #97

Closed
gregorko opened this issue Oct 12, 2014 · 4 comments
Closed

How can I add runner libraries #97

gregorko opened this issue Oct 12, 2014 · 4 comments

Comments

@gregorko
Copy link

@gregorko gregorko commented Oct 12, 2014

My project needs support of the jetty continuation library. According to http://akhikhl.github.io/gretty-doc/Servlet-container-classpath.html I use the following:

dependencies {
    gretty 'org.eclipse.jetty:jetty-continuation:9.2.3.v20140905'
}

This works fine when using appRun, but when using buildProduct, the continuation jar file is not added to the runner directory.

BTW: How can I say 'org.eclipse.jetty:jetty-continuation:[the same jetty version gretty is using]'?

@akhikhl
Copy link
Owner

@akhikhl akhikhl commented Oct 14, 2014

I'll have a look at the problem in the evening.
"same-version" syntax is not yet implemented, but should be easy to implement.

@akhikhl
Copy link
Owner

@akhikhl akhikhl commented Oct 14, 2014

I have good news for you:

  1. I implemented inclusion of "gretty" configuration into runner directory of the product.
  2. I implemented new properties giving you the needed version information:
project.ext {
  grettyVersion = Externalized.getString('grettyVersion')
  jetty7Version = Externalized.getString('jetty7Version')
  jetty7ServletApi = Externalized.getString('jetty7ServletApi')
  jetty7ServletApiVersion = Externalized.getString('jetty7ServletApiVersion')
  jetty8Version = Externalized.getString('jetty8Version')
  jetty8ServletApi = Externalized.getString('jetty8ServletApi')
  jetty8ServletApiVersion = Externalized.getString('jetty8ServletApiVersion')
  jetty9Version = Externalized.getString('jetty9Version')
  jetty9ServletApi = Externalized.getString('jetty9ServletApi')
  jetty9ServletApiVersion = Externalized.getString('jetty9ServletApiVersion')
  tomcat7Version = Externalized.getString('tomcat7Version')
  tomcat7ServletApi = Externalized.getString('tomcat7ServletApi')
  tomcat7ServletApiVersion = Externalized.getString('tomcat7ServletApiVersion')
  tomcat8Version = Externalized.getString('tomcat8Version')
  tomcat8ServletApi = Externalized.getString('tomcat8ServletApi')
  tomcat8ServletApiVersion = Externalized.getString('tomcat8ServletApiVersion')
}

"Externalized" means that these properties are build-driven, rather than hardcoded. This should guarantee, that these properties are always up-to-date and correspond the exact versions used by Gretty itself.
The properties are automatically injected into project.ext as soon as you apply Gretty plugin. So you don't have to configure anything to use these properties.
These changes are available in Gretty 1.1.5-SNAPSHOT. Could you, please, test it?

@akhikhl
Copy link
Owner

@akhikhl akhikhl commented Oct 15, 2014

Does 1.1.5-SNAPSHOT solve the problem for you?

@gregorko
Copy link
Author

@gregorko gregorko commented Oct 16, 2014

I just tested the 1.1.5 snapshot For me everything works as expected, gretty configuration and jetty9Version.

Thanks for the fast changes!

@gregorko gregorko closed this Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants