Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160819929 Customer can sign in to existing account #44

Merged
merged 3 commits into from
Oct 1, 2018

Conversation

akhilome
Copy link
Owner

@akhilome akhilome commented Oct 1, 2018

What does this PR do?

implement user login functionality and authentication with JSON web tokens.

Description of Task to be completed?

  • create POST /auth/login endpoint
  • install and use jsonwebtoken npm module
  • write tests for POST /auth/login
  • add JWT_SECRET to environmental variables
  • implement an authentication and authorization function

How should this be manually tested?

clone the repo and cd into it.

git clone https://github.com/akhilome/fast-food-fast.git && cd fast-food-fast

install dependencies and setup db

rename .env.example to .env and configure appropriately, then run

npm i && npm run setup-testdb

test away

npm test

What are the relevant pivotal tracker stories?

#160819929

- create POST /auth/login endpoint
- install and use jsonwebtoken
- write tests for POST /auth/login
- add JWT_SECRET to environmental variables

[Finishes #160819929]
@coveralls
Copy link

coveralls commented Oct 1, 2018

Coverage Status

Coverage decreased (-3.5%) to 92.828% when pulling 656b046 on ft-user-login-160819929 into 6624a4a on develop.

- write function for authorizing normal users
- write function for authorizing admin users
@akhilome akhilome merged commit de5f505 into develop Oct 1, 2018
@akhilome akhilome deleted the ft-user-login-160819929 branch October 8, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants