Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#163732462 Implement LF feedback #21

Merged
merged 4 commits into from
Feb 7, 2019
Merged

#163732462 Implement LF feedback #21

merged 4 commits into from
Feb 7, 2019

Conversation

akhilome
Copy link
Owner

@akhilome akhilome commented Feb 6, 2019

What does this PR do?

Implements LF feedback

Description of Task to be completed?

  • abstract localStorage calls to utils

How should this be manually tested?

N/A

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#163732462

Screenshots (if appropriate)

N/A

@coveralls
Copy link

coveralls commented Feb 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 71

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 99.627%
Totals Coverage Status
Change from base Build 62: 1.1%
Covered Lines: 267
Relevant Lines: 268
💛 - Coveralls

@akhilome akhilome merged commit db51afb into develop Feb 7, 2019
@akhilome akhilome deleted the ch-lf-feedback-163732462 branch February 7, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhilome @coveralls