Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature requests #9

Closed
tehniemer opened this issue Nov 11, 2020 · 15 comments
Closed

Feature requests #9

tehniemer opened this issue Nov 11, 2020 · 15 comments
Labels
enhancement New feature or request

Comments

@tehniemer
Copy link

tehniemer commented Nov 11, 2020

First off, thanks for publishing this, at first glance it seems much faster than a dockerized instance of gPodder that I've been running with for a while. However, the former has a few niceties, and missing features, that hopefully wouldn't be too hard to add:

  • Folder structure and file naming/tagging settings.
  • Directory scanning, Scan folders for existing files #8 or a "mark as downloaded" button if scanning directories isn't a trivial task.
  • A "download all" button to download episodes that aren't already on the disk.
  • An unplayed/played flag.
  • A grid layout option for the home page.
  • OPML export (thanks for adding import).
@akhilrex akhilrex added the enhancement New feature or request label Nov 12, 2020
@akhilrex
Copy link
Owner

I have added the following features. Just pull the latest image and rebuilt the container.

  • A "download all" button to download episodes that aren't already on the disk.
  • A delete all to delete episodes of a podcast
  • An unplayed/played flag.

Following are in development

  • OPML export (thanks for adding import).
  • A grid layout option for the home page.

@demslam
Copy link

demslam commented Jan 12, 2021

Excellent!

@undaunt
Copy link

undaunt commented Jan 13, 2021

Clicking download all on a podcast that I newly added (and thus have, for example, 5 episodes) appears to queue up the other downloads, but then nothing seems to be downloading. When I manually try to download 1 episode at a time, it works.

@akhilrex
Copy link
Owner

Hi @undaunt The background job runs at the frequency set in the env file (default 4 hrs). Please check if all episodes are downloaded after that interval has passed or not. If it is working you can reduce it to something smaller in the env file (30 mins maybe). I had originally kept a high default to avoid conflicts/locks of same job running twice but now that's handled in the code.

@undaunt
Copy link

undaunt commented Jan 14, 2021

I'll check, thanks!

Since conflicts are now handled in code could this action converted to an on demand action?

@akhilrex
Copy link
Owner

akhilrex commented Jan 14, 2021 via email

@akhilrex
Copy link
Owner

I'll check, thanks!

Since conflicts are now handled in code could this action converted to an on demand action?

Hi. This was fixed a couple of releases back. Though I would let you know.

@undaunt
Copy link

undaunt commented Jan 28, 2021

Thanks! Do you know what processes may or may not be running that would prevent this from triggering on demand? I added six shows to download all episodes earlier today and they are still queued.

@akhilrex
Copy link
Owner

akhilrex commented Feb 1, 2021

First off, thanks for publishing this, at first glance it seems much faster than a dockerized instance of gPodder that I've been running with for a while. However, the former has a few niceties, and missing features, that hopefully wouldn't be too hard to add:

  • Folder structure and file naming/tagging settings.
  • Directory scanning, Scan folders for existing files #8 or a "mark as downloaded" button if scanning directories isn't a trivial task.
  • A "download all" button to download episodes that aren't already on the disk.
  • An unplayed/played flag.
  • A grid layout option for the home page.
  • OPML export (thanks for adding import).

@tehniemer OMPL Export is live. Please pull the latest image and it should be there on the settings page.

@undaunt
Copy link

undaunt commented Feb 1, 2021

@akhilrex I had some downloads queued for over four days and they didn't download so I just did a fresh install today. They still don't appear to be running on demand. Anything in the logs I could look out for?

Thank you.

Edit: As a hunch, I tried turning on 'download new episodes automatically' and the downloads then worked after I re-selected one show to download.

Shouldn't the ability to download all episodes of a show not be predicated on the 'download new episodes automatically' feature? When I force download individual episodes, it simply works regardless.

@akhilrex
Copy link
Owner

akhilrex commented Feb 2, 2021 via email

@undaunt
Copy link

undaunt commented Feb 2, 2021

Hi Akhil,

I already rebuilt the container today. These issues persisted again today until I checked off 'download new episodes automatically' as I indicated above. Can you verify this checkbox is somehow being required for downloading all episodes of a podcast on demand?

settings

With those settings, I can manually download 1 file at a time, immediately, when I click download - but downloading all episodes never executes.

@akhilrex
Copy link
Owner

akhilrex commented Feb 2, 2021

That's strange. Please share the url of the podcast that you are trying and i will check it.

@undaunt
Copy link

undaunt commented Feb 3, 2021

It could be literally any podcast I have in my system. I have about 39 podcasts added.

For example:

Serial
Making
Lost Mountain Saga

As soon as I enable the 'automatically download new episodes to disk', then attempt to download all episodes of a different podcasts, both podcasts begin downloading.

If I then uncheck the option and add another podcast to the 'download all' queue, it sits there again.

I tested this both with, and without, the 'download episodes whenever a new podcast is added' enabled and it didn't seem to impact things. Only when 'automatically download new episodes to disk' is enabled will the podcasts download all episodes.

Again, this also doesn't impact single episode downloads, which always trigger as soon as I click them.

Unrelated but tangentially related, is there a reason all podcasts need to be queued (asking since I have 39 of them) for a 200 response before the one I just tried to download will begin downloading?

Thanks very much.

@akhilrex
Copy link
Owner

akhilrex commented Feb 4, 2021

Hi @undaunt I have created a new issue #39 to track your problem. Closing this one since all elements of this are done and deployed.

@akhilrex akhilrex closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants