Uneven border radii #267
Closed
Uneven border radii #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome implementation for flatpak! |
Alecaddd
reviewed
Jan 17, 2020
| if (is_radius_uniform) { | ||
| set ("radius-x", radius_x); | ||
| set ("radius-y", radius_x); | ||
| } else { |
There was a problem hiding this comment.
Use a return; here instead of an else.
There was a problem hiding this comment.
Yes, let me release that on a goocanvas-3.0 branch so we get any other improvement for free.
|
Should we revisit this now goocanvas 3.0 is out? https://mail.gnome.org/archives/ftp-release-list/2021-January/msg00074.html See #301 |
|
Yes, we definitely should! |
|
Now that goocanvas 3 is in, this is gonna be a kick-ass feature! |
|
Closing this since we dropped goocanvas and we're dealing with this directly in the app with Cairo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rectangles with uneven radius borders
Summary / How this PR fixes the problem?
Using an open MR from goocanvas
https://gitlab.gnome.org/GNOME/goocanvas/tree/wip/albfan/rect-radii
connect uneven border entries to edit corners.
Steps to Test
This works from flatpak. Using a submodule is another option not implemented
Screenshots
Known Issues / Things To Do
10/20allows to set x and y radius (to draw ellipsize cornersThis PR fixes/implements the following bugs/features: