Improve artboard item selection #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a into fix-artboard-item-selection
guillotjulien
pushed a commit
to guillotjulien/Akira
that referenced
this pull request
Aug 14, 2020
* Use bounds manager for boolean inside/outside artboard methods * Small code clean up * Use the bounds manager for item coordiantes and remove unused method * Mask items outside artboards and account for clipping masks * Use bounds manager for items selection inside artboard * Remove the canvas_redraw call * Temporarily disable clipping mask to make the CI happy * Add new feature in the release list * Prevent running the method if not necessary
guillotjulien
added a commit
to guillotjulien/Akira
that referenced
this pull request
Aug 14, 2020
This reverts commit abd76a9.
guillotjulien
added a commit
to guillotjulien/Akira
that referenced
this pull request
Aug 14, 2020
This reverts commit abd76a9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
Artboards are a whole new beast that need a lot of work, so let's start doing some small PRs to slowly improve them.
Steps to Test
Screenshots
Known Issues / Things To Do
simple_is_item_atin the current state accounts only for the item's bounding box. This is not optimal as it should only react when the pointer is inside the actual path, and ignore it when it's on the empty area.This PR fixes/implements the following bugs/features:
canvas_redrawmethod