-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to setup TLS #352
Comments
This may include:
|
@raboof other than cross-linking to sections of the docs you mentioned, do you think any extra documentation is necessary? I was thinking that a new section in https://doc.akka.io/docs/akka-grpc/current/deploy.html or https://doc.akka.io/docs/akka-grpc/current/troubleshooting.html could be enough to detail each problem and a brief description of the solution and link to the corresponding existing docs. |
@raboof One of the reasons I'd rather keep this minimal is that both |
Good point! I agree pointing to the Akka HTTP docs (and perhaps improving those a bit? or are they OK?) should be sufficient. We can point to 10.1 now and update both the dependency and the documentation reference to 10.2.0 when that comes out |
Here's some sample code I used while investigating the work requried for this issue. |
After #912 I did a review of what's already documented to setup TLs on the client-side and found https://doc.akka.io/docs/akka-grpc/current/client/configuration.html contains all the necessary information. I think we can mark this issue as completed. |
Sorry to jump in here. I was lead to this issue by this section of the docs: https://doc.akka.io/docs/akka-grpc/current/server/walkthrough.html#serving-the-service-with-akka-http I'm hoping that's the part that needs updating for this issue to be closed. |
Good catch @esamson! I'll remove that TODO and cross-link the walkthrough to the |
No description provided.
The text was updated successfully, but these errors were encountered: