feat: Load client config from arbitrary config block #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
approved these changes
Sep 9, 2024
| def fromConfig(clientName: String, config: Config)( | ||
| implicit actorSystem: ClassicActorSystemProvider): GrpcClientSettings = { | ||
| // Use config named "*" by default | ||
| val defaultServiceConfig = actorSystem.classicSystem.settings.config.getConfig("akka.grpc.client.\"*\"") |
There was a problem hiding this comment.
I was considering if this should be config.withFallback(actorSystem.classicSystem.settings.config) in case the given config also overrides default config, but fine to not support that kind of override.
There was a problem hiding this comment.
Hmm, yeah, maybe not a bad idea.
There was a problem hiding this comment.
Let's leave that and revisit in case we figure out that it is very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.