=htc replace usage of RuleNotFoundException by introducing explicit result ADT
#1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. |
jrudolph
force-pushed
the
jr/w/remote-header-parser-RuleNotFoundException
branch
from
74a8722
to
5170d5f
Compare
|
Added missing mima filters. |
akka-ci
added
validating
|
Test FAILed. |
jrudolph
force-pushed
the
jr/w/remote-header-parser-RuleNotFoundException
branch
from
5170d5f
to
501661e
Compare
akka-ci
added
validating
|
Test PASSed. |
raboof
approved these changes
Sep 14, 2017
| @@ -0,0 +1,7 @@ | |||
| # Changes to internal API | |||
| ProblemFilters.exclude[MissingClassProblem]("akka.http.impl.model.parser.HeaderParser$RuleNotFoundException$") | |||
There was a problem hiding this comment.
Can we ProblemFilters.exclude[Problem]("akka.http.impl.*")?
There was a problem hiding this comment.
I guess we can. It's somewhat interesting to see what has changed in the API but it's mostly distracting so I'll try.
| @@ -62,18 +62,21 @@ private[http] class HeaderParser( | |||
|
|
|||
| ///////////////// DynamicRuleHandler ////////////// | |||
|
|
|||
| type Result = Either[ErrorInfo, HttpHeader] | |||
| type Result = HeaderParser.Result | |||
There was a problem hiding this comment.
I was confused why not just use HeaderParser.Result directly, but this is specifying the Result from DeliveryScheme.
It looks like type also accepts an override modifier, might be a nice way to make that explicit?
| case NonFatal(e) ⇒ ErrorInfo.fromCompoundString(e.getMessage) | ||
| } | ||
| } | ||
| def ruleNotFound(ruleName: String): Result = HeaderParser.RuleNotFound |
… result ADT Before every attempt to parse an unknown (i.e. not modeled) header would end up in throwing and catching an exception. This does not really make sense as parboiled already provides for delivering these signals without an exception. Refs playframework/playframework#7822
jrudolph
force-pushed
the
jr/w/remote-header-parser-RuleNotFoundException
branch
from
501661e
to
b181ffa
Compare
akka-ci
added
validating
|
Test PASSed. |
jrudolph
deleted the
jr/w/remote-header-parser-RuleNotFoundException
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before every attempt to parse an unknown (i.e. not modeled) header would
end up in throwing and catching an exception. This does not really make
sense as parboiled already provides for delivering these signals without
an exception.
Refs playframework/playframework#7822