New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinConnections can not be configured on a specific ConnectionPoolSettings #1525

Closed
RustedBones opened this Issue Nov 12, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@RustedBones

RustedBones commented Nov 12, 2017

I am writing a small library that uses the akka-http host connection pool client to interact with an external system.

For this library, I don't want to use the default akka.http.host-connection-pool configuration but a very specific one. This to ensure that other usage of Http().cachedHostConnectionPool(...) in the final application do not use the same pool configuration as the library.

To do this, I've done the following:

private val connectionPoolSettings = ConnectionPoolSettings(system)
    .withMaxConnections(maxConnections)
    .withMaxOpenRequests(maxConnections)
    .withMaxRetries(maxRetries)

This seems to be the easiest way to go, because it allows using the default settings and only overwrite the interesting values.

However, ConnectionPoolSettings does not provide a modifier for minConnections. I suppose this has just been forgotten.

RustedBones pushed a commit to RustedBones/akka-http that referenced this issue Nov 12, 2017

jrudolph added a commit that referenced this issue Nov 14, 2017

Merge pull request #1526 from RustedBones/connection-pool-settings-mi…
…n-connections-modifier

Add minConnections modifier to ConnectionPoolSettings #1525

@jrudolph jrudolph added this to the 10.0.11 milestone Nov 14, 2017

@jrudolph

This comment has been minimized.

Show comment
Hide comment
@jrudolph

jrudolph Nov 14, 2017

Member

Fixed in #1526.

Member

jrudolph commented Nov 14, 2017

Fixed in #1526.

@jrudolph jrudolph closed this Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment