Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MiMa and Fix binary incompatibilities #870

Closed
jlprat opened this issue Feb 17, 2017 · 2 comments
Closed

Update MiMa and Fix binary incompatibilities #870

jlprat opened this issue Feb 17, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@jlprat
Copy link
Member

jlprat commented Feb 17, 2017

MiMa doesn't have entries for releases 10.0.2 and 10.0.3 this implies that all PR's since then were not properly checked by MiMa, causing some binary incompatibilities.
Currently these are:

  • akka-http-spray-json:
    • method sprayJsValueByteStringUnmarshaller()akka.http.scaladsl.unmarshalling.Unmarshaller in trait akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport is present only in current version filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport.sprayJsValueByteStringUnmarshaller")
  • akka-http:
    • method fromEntityStreamingSupportAndEntityMarshaller(akka.http.scaladsl.common.EntityStreamingSupport,akka.http.scaladsl.marshalling.Marshaller,scala.reflect.ClassTag)akka.http.scaladsl.marshalling.Marshaller in trait akka.http.scaladsl.marshalling.LowPriorityToResponseMarshallerImplicits is present only in current version filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.http.scaladsl.marshalling.LowPriorityToResponseMarshallerImplicits.fromEntityStreamingSupportAndEntityMarshaller")
    • method andThen(akka.http.scaladsl.unmarshalling.Unmarshaller)akka.http.scaladsl.unmarshalling.Unmarshaller in trait akka.http.scaladsl.unmarshalling.Unmarshaller is present only in current version filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.http.scaladsl.unmarshalling.Unmarshaller.andThen")
  • akka-http-core:
    • method parsingRendering(akka.http.scaladsl.settings.ServerSettings,akka.event.LoggingAdapter)akka.stream.scaladsl.BidiFlow in object akka.http.impl.engine.server.HttpServerBluePrint does not have a correspondent in current version filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("akka.http.impl.engine.server.HttpServerBluePrint.parsingRendering")
    • method apply(akka.http.scaladsl.settings.ServerSettings,akka.event.LoggingAdapter)akka.stream.scaladsl.BidiFlow in object akka.http.impl.engine.server.HttpServerBluePrint does not have a correspondent in current version filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("akka.http.impl.engine.server.HttpServerBluePrint.apply")
    • method parsing(akka.http.scaladsl.settings.ServerSettings,akka.event.LoggingAdapter)akka.stream.scaladsl.Flow in object akka.http.impl.engine.server.HttpServerBluePrint does not have a correspondent in current version filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("akka.http.impl.engine.server.HttpServerBluePrint.parsing")

I guess the proper 10.0.*.backwards.excludes files must be added for those projects

@jlprat
Copy link
Member Author

jlprat commented Feb 17, 2017

After putting the right .backwards.excludes files in place these are the current binary incompats:
akka-http-core: found 2 potential binary incompatibilities while checking against com.typesafe.akka:akka-http-core_2.11:10.0.3 (filtered 7)

  • class akka.http.impl.util.StreamUtils#AbsorbCancellationStage does not have a correspondent in current version filter with: ProblemFilters.exclude[MissingClassProblem]("akka.http.impl.util.StreamUtils$AbsorbCancellationStage")
  • method absorbCancellation()akka.stream.scaladsl.Flow in object akka.http.impl.util.StreamUtils does not have a correspondent in current version filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("akka.http.impl.util.StreamUtils.absorbCancellation")

jlprat added a commit to jlprat/akka-http that referenced this issue Feb 17, 2017
Issue: akka#870
* Update MiMa to track 10.0.2 and 10.0.3
* Add exclusion files for akka-http-core, akka-http and akka-http-spray-json
jlprat added a commit to jlprat/akka-http that referenced this issue Feb 17, 2017
Issue: akka#870
* Update MiMa to track 10.0.2 and 10.0.3
* Add exclusion files for akka-http-core, akka-http and akka-http-spray-json
jrudolph added a commit that referenced this issue Feb 20, 2017
Update MiMa to track 10.0.2 and 10.0.3 and update exclusions #870
@jrudolph jrudolph added the bug label Feb 20, 2017
@jrudolph jrudolph added this to the 10.0.4 milestone Feb 20, 2017
@jrudolph
Copy link
Member

Fixed by #871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants