Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Default Scala quickstart to Scala 3, test on both 3 and 2.13 #4405

Merged
merged 3 commits into from
Sep 24, 2024
Merged

docs: Default Scala quickstart to Scala 3, test on both 3 and 2.13 #4405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2d49b1
docs: Default Scala quickstart to Scala 3, test on both 3 and 2.13
johanandren May 20, 2024
169fb67
ups ++ ran away
johanandren May 20, 2024
65cd623
Must build scala artifacts for 3 as well
johanandren May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/check-samples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:

- name: Publish artifacts locally
run: |-
sbt "publishLocal; publishM2"
sbt "+publishLocal; publishM2"

- name: Test akka-http-quickstart-java
run: |-
Expand All @@ -63,7 +63,8 @@ jobs:
- name: Test akka-http-quickstart-scala
run: |-
cd samples/akka-http-quickstart-scala
sbt test -Dakka-http.version=`cat ~/.version`
sbt "++2.13.14!; test;" -Dakka-http.version=`cat ~/.version`
sbt "clean; test;" -Dakka-http.version=`cat ~/.version`

- name: Email on failure
if: ${{ failure() }}
Expand Down
2 changes: 1 addition & 1 deletion samples/akka-http-quickstart-scala/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ lazy val root = (project in file(".")).
settings(
inThisBuild(List(
organization := "com.example",
scalaVersion := "2.13.14"
scalaVersion := "3.3.3"
)),
name := "akka-http-quickstart",
libraryDependencies ++= Seq(
Expand Down
Loading