javadsl for CassandraProjection #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
reviewed
Apr 30, 2020
| @@ -49,6 +49,7 @@ import akka.stream.alpakka.cassandra.scaladsl.CassandraSession | |||
| Instant.now(clock)) | |||
| } | |||
|
|
|||
| // FIXME maybe we need to make this public for user's tests | |||
There was a problem hiding this comment.
Is this something we could do on initialization or lazily (or try to do) if the keyspace and table DNE?
There was a problem hiding this comment.
it should not be automatic, but we probably need to expose it for test
akka-projection-cassandra/src/main/scala/akka/projection/cassandra/javadsl/Handler.scala
Show resolved
Hide resolved
patriknw
force-pushed
the
wip-21-javadsl-patriknw
branch
from
e1cb0d5
to
b9ebe36
Compare
|
I have added CassandraProjectionTest with javadsl.ProjectionTestKit b9ebe36 so this is ready for final review. |
* CassandraProjectionTest with javadsl.ProjectionTestKit
patriknw
force-pushed
the
wip-21-javadsl-patriknw
branch
from
e76e1c2
to
8a0df5b
Compare
octonato
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't write any tests because we need javadsl of the testkit first, but I have prepared for the junit testing. #83
References #21