Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish Source.queue #18890

Closed
ktoso opened this issue Nov 9, 2015 · 5 comments
Closed

Polish Source.queue #18890

ktoso opened this issue Nov 9, 2015 · 5 comments
Labels
t:stream
Milestone
2.4.2

Comments

@ktoso
Copy link
Member

ktoso commented Nov 9, 2015

It's not quite complete yet, open questions:

  • how to signal completion (there's only offer, we need some form of complete as well)
  • how to signal error (there's only offer, we need some form of complete as well)
  • offer returns a Future[Boolean] but it can return spurious true because early termination
  • it is very unclear how the user is supposed to encode their sender, should they do some async-tailcall-based thing?
  • creating the SourceQueue should not take a timeout, and especially not one with an arbitrary timeout value (5 seconds in the current source tree), if anything the entity which calls offer needs to specify any timeouts. It can also be argued that this functionality does not need to be embedded within the SourceQueue at all.
@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:stream labels Nov 9, 2015
@ktoso ktoso added this to the streams-2.0-M2 milestone Nov 9, 2015
@viktorklang viktorklang mentioned this issue Nov 9, 2015
Closed
@viktorklang
Copy link
Member

Also, there is a bit of possible overlap with Source.maybe

@viktorklang
Copy link
Member

Updated the Issue description to also consider timeouts

@drewhk drewhk modified the milestones: streams-2.0-M2, streams-2.0-M3 Nov 27, 2015
@rkuhn rkuhn modified the milestones: streams-2.0-M3, streams-2.0 Dec 16, 2015
@agolubev
Copy link
Contributor

starting this if no objections.
This should be migrated to graph stage.

@He-Pin
Copy link
Member

He-Pin commented Dec 17, 2015

+1,we are migrating to GraphStage anyway.

@drewhk
Copy link
Member

drewhk commented Dec 17, 2015

@agolubev go ahead!

@ktoso ktoso modified the milestones: streams-2.0, streams-backlog Dec 21, 2015
agolubev added a commit to agolubev/akka that referenced this issue Dec 26, 2015
@agolubev
=str akka#18890 Polish Source.queue
151a6e2
agolubev added a commit to agolubev/akka that referenced this issue Dec 26, 2015
@agolubev
=str akka#18890 Polish Source.queue
d63b4ac
agolubev added a commit to agolubev/akka that referenced this issue Dec 26, 2015
@agolubev
=str akka#18890 Polish Source.queue
d0802d0
agolubev added a commit to agolubev/akka that referenced this issue Dec 26, 2015
@agolubev
=str akka#18890 Polish Source.queue
de505db
@agolubev agolubev mentioned this issue Dec 26, 2015
Closed
@ktoso ktoso added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Dec 27, 2015
agolubev added a commit to agolubev/akka that referenced this issue Dec 31, 2015
@agolubev
=str akka#18890 Polish Source.queue
74a99ca
agolubev added a commit to agolubev/akka that referenced this issue Jan 7, 2016
@agolubev
=str akka#18890 Polish Source.queue
4c29c1d
agolubev added a commit to agolubev/akka that referenced this issue Jan 7, 2016
@agolubev
=str akka#18890 Polish Source.queue
25f8fd1
agolubev added a commit to agolubev/akka that referenced this issue Jan 17, 2016
@agolubev
=str akka#18890 Polish Source.queue
2967778
agolubev added a commit to agolubev/akka that referenced this issue Jan 17, 2016
@agolubev
=str akka#18890 Polish Source.queue
5178f4f
@agolubev agolubev mentioned this issue Jan 17, 2016
Merged
agolubev added a commit to agolubev/akka that referenced this issue Jan 18, 2016
@agolubev
=str akka#18890 Polish Source.queue
cf06ca0
agolubev added a commit to agolubev/akka that referenced this issue Jan 18, 2016
@agolubev
=str akka#18890 Polish Source.queue
515f613
agolubev added a commit to agolubev/akka that referenced this issue Jan 21, 2016
@agolubev
=str akka#18890 Polish Source.queue
d5f81e1
rkuhn added a commit that referenced this issue Jan 22, 2016
@rkuhn
Merge pull request #19489 from agolubev/agolubev-#18890_polish-Source…
ba14bb4 
….queue

Agolubev #18890 polish source.queue
@rkuhn rkuhn modified the milestones: 2.4.2, stream-backlog Jan 22, 2016
@rkuhn rkuhn closed this as completed Jan 22, 2016
agolubev added a commit to agolubev/akka that referenced this issue Jan 23, 2016
@agolubev
=str akka#18890 fix throttle
b4ec077 
- the constant cost function should is reused instead of allocated per use
- use nanoTime insted of millis
@agolubev agolubev mentioned this issue Jan 23, 2016
Merged
agolubev added a commit to agolubev/akka that referenced this issue Jan 25, 2016
@agolubev
=str akka#18890 fix throttle
5caddda
agolubev added a commit to agolubev/akka that referenced this issue Feb 12, 2016
@agolubev
=str akka#18890 fix throttle
f7d23b5
rkuhn added a commit that referenced this issue Feb 12, 2016
@rkuhn
Merge pull request #19595 from agolubev/agolubev-#19316-fix-throttle
7a41768 
=str #18890 fix throttle
@ktoso ktoso removed the 3 - in progress Someone is working on this ticket label Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t:stream
Projects
None yet
Milestone
2.4.2
Development

No branches or pull requests
6 participants
@viktorklang @ktoso @agolubev @rkuhn @He-Pin @drewhk