move multi-node-testkit into its own module, see #2981 #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,7 +98,9 @@ object AkkaBuild extends Build { | |||
| id = "akka-dataflow", | |||
| base = file("akka-dataflow"), | |||
| dependencies = Seq(actor, testkit % "test->test"), | |||
| settings = defaultSettings ++ scaladocSettings ++ OSGi.dataflow ++ cpsPlugin | |||
| settings = defaultSettings ++ scaladocSettings ++ OSGi.dataflow ++ cpsPlugin ++ Seq( | |||
| previousArtifact := akkaPreviousArtifact("akka-dataflow") | |||
|
LGTM |
|
Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/480/ |
|
jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/480/ |
| into the stable core but are still marked “experimental” at this point. This | ||
| does not mean that they do not function as intended, it primarily means that | ||
| their API has not yet solidified enough in order to be considered frozen. You | ||
| can help accelerating this process by giving feedback on these modules on our |
There was a problem hiding this comment.
accelerating → accelerate
|
LGTM |
|
This is not everything. Search the file system and you will see more references to |
|
Are you sure that you are looking at my branch? I cannot find anything. |
|
I can't see that you have touched multi-node-log-replace.sh, which contains reference to akka-remote-tests-experimental |
|
oh, directories starting with “s” were under the radar for me until now, thanks for catching this! |
|
:-) yeah, why would someone care about "s" directories |
rkuhn
added a commit
that referenced
this pull request
Feb 11, 2013
move multi-node-testkit into its own module, see #2981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.