fix RemoteDeathWatchSpec and improve logging #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it is customary to use class name for categorizing logs, hence we should support it; class is taken from logSource.getClass - update SLF4J module to use logClass as category and set logSource in MDC "akkaSource" - add docs
- ELAR extended DeadLetterActorRef, which is serialized specially, not keeping the name - made deadletter behavior a trait, mix that into both and only override writeReplace in DLAR - remove extraneous debug settings from RemoteDeathWatchSpec
| testActor ! "ping" | ||
| expectMsg("ping") | ||
| "notify with one Terminated message when an Actor is already dead" in { | ||
| val terminal = system.actorOf(Props(context ⇒ { case _ ⇒ })) |
There was a problem hiding this comment.
Doesn't system.actorOf(Props.empty) work better?
There was a problem hiding this comment.
works the same, but will change to the cleaner variant
|
Looks like something you're really enjoying ;-) +1 from me |
|
well, I certainly enjoy good debug output when encountering bugs ;-) |
| * } | ||
| * }}} | ||
| */ | ||
| //def getLogger(bus: LoggingBus, logSource: AnyRef): LoggingAdapter = apply(bus, LogSource.fromAnyRef(logSource)) |
There was a problem hiding this comment.
dead comment. FIXME, TICKET or REMOVE
There was a problem hiding this comment.
d’oh: forgot to re-enable, only commented out to ensure that we are not using it ourselves (because I wanted all logging to include system name if possible).
- tons of documentation added - lift extraction of logClass into LogSource type-class - prefer Props.empty
|
okay, feedback was good (also necessary) and incorporated. send smileys my way ;-) |
|
:) |
1 similar comment
|
:) |
rkuhn
added a commit
that referenced
this pull request
Jan 13, 2012
fix RemoteDeathWatchSpec and improve logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple tickets: 1591, 1621, 1622