Change typed whenTerminated sig to Future[Done], #25647 #26644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
added
the
2 - pick next
akka-ci
added
validating
|
Test PASSed. |
johanandren
approved these changes
Apr 1, 2019
| override def getWhenTerminated: CompletionStage[Terminated] = FutureConverters.toJava(whenTerminated) | ||
| private val terminationPromise = Promise[Done] | ||
| override def terminate(): Unit = terminationPromise.trySuccess(Done) | ||
| override def whenTerminated: Future[Done] = terminationPromise.future.map(_ => Done)(sameThreadExecutionContext) |
There was a problem hiding this comment.
No need to map if it is already a Future[Done]
This change ignore the terminated passed from untyped and map it into Done, with some minor changes for testing termination. termiate() returns Unit to not bias it towards the Scala API, completion can be observed with whenTerminated or getWhenTerminated
patriknw
force-pushed
the
wip-whenTerminate-patriknw
branch
from
0200d7f
to
7cc6266
Compare
akka-ci
added
validating
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #25651
Also changed
terminate()to returnUnitto not bias it towards the Scala API, completion can be observed with whenTerminated or getWhenTerminatedRefs #25647