[WIP] 2.5 backport of stream cancellation modes #27608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrudolph
added a commit
to jrudolph/akka-http
that referenced
this pull request
Sep 2, 2019
akka-ci
added
tested
|
Test PASSed. |
|
Superseded by #28008. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's not the final thing but rather a first try of providing a minimal backport of new stream cancellation features in 2.6. The idea is not backport stream cancellation causes but still provide the possibility to configure stream cancellation modes (as suggested in #27594). We cannot provide the new
PropagateFailuresmode (because there are no causes to propagate in 2.5). In akka-http we can still use theAfterDelaymode to introduce a general cancellation delay stages which seems to be enough to fix the so far elusive cancellation race conditions.