Improve ReliableProxy resend across a slow link, see #2849 #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| runOn(local) { | ||
| testConductor.throttle(local, remote, Direction.Send, rateMBit = 0.1).await | ||
| testConductor.throttle(local, remote, Direction.Send, rateMBit = 0.02).await |
There was a problem hiding this comment.
Perhaps a small comment indicating the choice of this seemingly magic value?
There was a problem hiding this comment.
um, it's derived from empirical studies :-)
|
yes, LGTM |
|
Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/277/ |
|
jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/277/ |
|
Merge? |
* The within margin was too small. On my machine the transition to Idle is done when 400 ms is remaining, which is too timing sensitive. * Improved the "resend across a slow link" test to actually trigger resending, which it didn't do before.
patriknw
added a commit
that referenced
this pull request
Jan 4, 2013
…k-patriknw Improve ReliableProxy resend across a slow link, see #2849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when 400 ms is remaining, which is too timing sensitive.
which it didn't do before.