Improve ReliableProxy resend across a slow link, see #2849 #998

Merged
merged 1 commit into from Jan 4, 2013

4 participants

@patriknw
Akka Project member
  • The within margin was too small. On my machine the transition to Idle is done when 400 ms is remaining, which is too timing sensitive.
  • Improved the "resend across a slow link" test to actually trigger resending, which it didn't do before.
@viktorklang viktorklang and 1 other commented on an outdated diff Jan 4, 2013
...vm/scala/akka/contrib/pattern/ReliableProxySpec.scala
runOn(local) {
- testConductor.throttle(local, remote, Direction.Send, rateMBit = 0.1).await
+ testConductor.throttle(local, remote, Direction.Send, rateMBit = 0.02).await
@viktorklang
Akka Project member
viktorklang added a line comment Jan 4, 2013

Perhaps a small comment indicating the choice of this seemingly magic value?

@patriknw
Akka Project member
patriknw added a line comment Jan 4, 2013

um, it's derived from empirical studies :-)

@patriknw
Akka Project member
patriknw added a line comment Jan 4, 2013

added the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@viktorklang viktorklang and 1 other commented on an outdated diff Jan 4, 2013
...vm/scala/akka/contrib/pattern/ReliableProxySpec.scala
runOn(local) {
testConductor.passThrough(local, remote, Direction.Send).await
- testConductor.throttle(local, remote, Direction.Receive, rateMBit = 0.1).await
+ testConductor.throttle(local, remote, Direction.Receive, rateMBit = 0.02).await
sendN(50)
within(5 seconds) {
@viktorklang
Akka Project member
viktorklang added a line comment Jan 4, 2013

Is this still a sensible figure with the Thread.sleep inside?

@patriknw
Akka Project member
patriknw added a line comment Jan 4, 2013

yes, it normally completes this part in 2.5 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rkuhn

yes, LGTM

@akka-ci
Akka Project member

Started jenkins job akka-pr-validator at https://jenkins.akka.io/job/akka-pr-validator/277/

@akka-ci
Akka Project member

jenkins job akka-pr-validator: Success - https://jenkins.akka.io/job/akka-pr-validator/277/

@viktorklang
Akka Project member

Merge?

@patriknw patriknw Improve ReliableProxy resend across a slow link, see #2849
* The within margin was too small. On my machine the transition to Idle is done
  when 400 ms is remaining, which is too timing sensitive.
* Improved the "resend across a slow link" test to actually trigger resending,
  which it didn't do before.
06f1945
@patriknw patriknw merged commit c7484fc into master Jan 4, 2013
@patriknw patriknw deleted the wip-2849-ReliableProxySpec-slow-link-patriknw branch Jan 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment