Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google FCM: become Alpakka 1.0 ready #1075

Closed
4 tasks done
ennru opened this issue Jul 4, 2018 · 2 comments
Closed
4 tasks done

Google FCM: become Alpakka 1.0 ready #1075

ennru opened this issue Jul 4, 2018 · 2 comments

Comments

@ennru
Copy link
Member

ennru commented Jul 4, 2018

  • Move internal code to impl package
  • Mark internal code @InternalApi and private[connector]
  • Move documentation example code to packages docs.javadsl and docs.scaladsl
  • Make settings to be non-case classes
@tg44
Copy link
Contributor

tg44 commented Jul 6, 2018

Hey!

Moving documentation code means; from the tests to the docs?

Why we make settings to non-case classes?

BTW this component has more todo-s. Most of the fields must be option (which was not described in the fcm-docs but came out in real use), the akka-docs should describe some retry mechanism, and use-cases.

@ennru
Copy link
Member Author

ennru commented Jul 6, 2018

The example code should be moved to another package. Still to be run as tests. That way we can make sure the docs don't reference any internal classes.

Case-classes cannot be evolved in a binary-compatible way.

Please add issues for other things that should be fixed before we promote the module to being API-stable.

@2m 2m closed this as completed in #1477 Feb 4, 2019
@2m 2m added this to the 1.0-M3 milestone Feb 4, 2019
@2m 2m added the api-change label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants