Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couchbase: Akka Discovery support #1746

Merged
merged 8 commits into from
Jun 28, 2019
Merged

Couchbase: Akka Discovery support #1746

merged 8 commits into from
Jun 28, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Jun 7, 2019

Purpose

Add support for use of Akka Discovery to configure Couchbase nodes.

Changes

  • Add enrichAsync to CouchbaseSessionSettings
  • Apply enrichAsync before using settings
  • Test case with DiscoverySupport usage
  • Documentation

@ennru ennru mentioned this pull request Jun 17, 2019
Closed
15 tasks
2m
2m approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is nice how we were able to get away with refactoring settings resolution to async. We will not get lukcy like that with other connectors. :)

@2m
Copy link
Member

2m commented Jun 25, 2019

Needs a rebase.

@ennru ennru mentioned this pull request Jun 25, 2019
Merged
ignasi35
ignasi35 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the nodes function as part of the settings object. :-)

couchbase/src/main/java/akka/stream/alpakka/couchbase/javadsl/DiscoverySupport.java Show resolved Hide resolved
couchbase/src/main/scala/akka/stream/alpakka/couchbase/scaladsl/DiscoverySupport.scala Show resolved Hide resolved
@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. documentation labels Jun 28, 2019
@ennru ennru changed the title WIP Couchbase: Akka Discovery support Couchbase: Akka Discovery support Jun 28, 2019
johanandren
johanandren approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

couchbase/src/main/scala/akka/stream/alpakka/couchbase/model.scala Outdated Show resolved Hide resolved
couchbase/src/main/scala/akka/stream/alpakka/couchbase/scaladsl/DiscoverySupport.scala Show resolved Hide resolved
@ennru ennru added this to the 1.1.0 milestone Jun 28, 2019
@ennru ennru merged commit d291270 into akka:master Jun 28, 2019
@ennru ennru deleted the discovery-for-couchbase branch June 28, 2019 12:26
cheleb pushed a commit to cheleb/alpakka that referenced this pull request Jul 5, 2019
@ennru
Couchbase: Akka Discovery support (akka#1746)
92b07c4
@ignasi35 ignasi35 mentioned this pull request Nov 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasi35 ignasi35 ignasi35 approved these changes

@johanandren johanandren johanandren approved these changes

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
dependency-change For PRs changing the version of a dependency. documentation p:couchbase
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ennru @2m @johanandren @ignasi35