Add imports to Ftp settings sample, actually run listFiles #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
commented
Jul 4, 2019
| throws Exception { | ||
| return Ftp.ls(basePath, settings); | ||
| Ftp.ls(basePath, settings) | ||
| .runForeach(ftpFile -> System.out.println(ftpFile.toString()), materializer); |
There was a problem hiding this comment.
Not quite sure about this one: on the one hand it is nice to show in the example that this produces a source of FtpFile, on the other hand I think it is good to show actually running the stream, not just creating it, especially in 'early' examples.
There was a problem hiding this comment.
I agree. The FTP examples are from the early days of Alpakka...
ennru
approved these changes
Jul 4, 2019
| throws Exception { | ||
| return Ftp.ls(basePath, settings); | ||
| Ftp.ls(basePath, settings) | ||
| .runForeach(ftpFile -> System.out.println(ftpFile.toString()), materializer); |
There was a problem hiding this comment.
I agree. The FTP examples are from the early days of Alpakka...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.