Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 2.12.10; Akka 2.6-M8; Akka HTTP 10.1.10 #1939

Merged
merged 9 commits into from
Oct 2, 2019
Merged

Scala 2.12.10; Akka 2.6-M8; Akka HTTP 10.1.10 #1939

merged 9 commits into from
Oct 2, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Sep 20, 2019 •
edited
Loading

  • Use Scala 2.12.10
  • Use Akka 2.6.0-M8
  • Use Akka HTTP 10.1.10 to get an Akka 2.6 compatible version

(Scala 2.13.1 lacks the Silencer plugin at the moment.)

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Sep 20, 2019
@ennru ennru changed the title Scala 2.12.10 and 2.13.1; Akka 2.6-M7 Scala 2.12.10; Akka 2.6-M7 Sep 20, 2019
@ennru
Copy link
Member Author

ennru commented Sep 23, 2019

Failures were

@ennru ennru changed the title Scala 2.12.10; Akka 2.6-M7 Scala 2.12.10; Akka 2.6-M7; Akka HTTP 10.1.10 Sep 23, 2019
@ennru ennru changed the title Scala 2.12.10; Akka 2.6-M7; Akka HTTP 10.1.10 Scala 2.12.10; Akka 2.6-M8; Akka HTTP 10.1.10 Sep 30, 2019
@ennru ennru requested a review from seglo October 1, 2019 14:53
@ennru
Copy link
Member Author

ennru commented Oct 1, 2019

For the cron builds it is important to get the Akka HTTP upgrade in.

seglo
seglo approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment about choosing the project Scala version.

project/Common.scala Outdated Show resolved Hide resolved
@ennru ennru merged commit 941f249 into akka:master Oct 2, 2019
@ennru ennru deleted the scala-versions branch October 2, 2019 15:01
ennru added a commit to ennru/alpakka that referenced this pull request Oct 4, 2019
@ennru
Scala 2.12.10; Akka 2.6-M8; Akka HTTP 10.1.10 (akka#1939)
4aac69d 
* Update Scala to 2.12.10 in sbt and Travis
* Latest silencer compiler plugin
* Akka HTTP 10.1.8 to 10.1.10 for Akka 2.6 compatibility
* Akka 2.6.0-M8
ennru added a commit that referenced this pull request Oct 4, 2019
@ennru
Merge pull request #1969 from ennru/backport-1939
7b1da6d 
[Backport #1939] Scala 2.12.10; Akka 2.6-M8; Akka HTTP 10.1.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees
No one assigned
Labels
alpakka-itself dependency-change For PRs changing the version of a dependency. p:aws-s3 p:aws-sns p:aws-sqs p:ironmq p:sse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @seglo