DynamoDB: flow with pagination #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
approved these changes
Oct 15, 2019
| Pair<PutItemResponse, SomeContext> response = | ||
| streamCompletion.toCompletableFuture().get(1, TimeUnit.SECONDS); | ||
| fail("expected missing schema"); | ||
| } catch (ExecutionException expected) { |
There was a problem hiding this comment.
From which library? JUnit 4 nor Hamcrest have it.
There was a problem hiding this comment.
It looks like it's part of the Test attribute in JUnit 4.
@Test(expected = IndexOutOfBoundsException.class)
public void empty() {
new ArrayList<Object>().get(0);
}
There was a problem hiding this comment.
Ah right, haven't used that for a while.
| try { | ||
| List<ScanResponse> strings = streamCompletion2.toCompletableFuture().get(1, TimeUnit.SECONDS); | ||
| fail("expected missing schema"); | ||
| } catch (ExecutionException expected) { |
docs/src/main/paradox/dynamodb.md
Outdated
| ### Flow with context | ||
|
|
||
| The `flowWithContext` allows to send an arbitrary value, such as commit handles for JMS or Kafka, past the DynamoDb operation. | ||
| The responses are wrapped in a @scaladoc[Try](scala.util.Try)] to differentiate between successful operations and errors in-stream. |
There was a problem hiding this comment.
Typo with a trailing ] on the scaladoc link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Offer the paginating DynamoDB operations as a flow.
Background Context
When @julianhowarth pointed out in #767 (comment) I discovered that the
GetBatchItemoperation wasn't prepared for use with pagination in Alpakka.While at it I added a
flowPaginatedfor use of paginated results in flows to complement the source and added some documentation forflowWithContext.(The use of a
RetryFlowis still pending, we might want to remove theTryfrom the Java API.)