Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 request uri: include empty trailing slashes for the key #2095

Merged
merged 2 commits into from
Jan 16, 2020
Merged

S3 request uri: include empty trailing slashes for the key #2095

merged 2 commits into from
Jan 16, 2020

Conversation

dl-mai
Copy link
Contributor

@dl-mai dl-mai commented Jan 15, 2020

Purpose

prevent vanishing trailing slash in s3 objects keys

References

References #2089

Changes

  • change key split in a way it does not remove trailing empty slashes

Background Context

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

ennru
ennru approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little fix.
LGTM.

@ennru ennru added this to the 2.0.0 milestone Jan 16, 2020
@ennru ennru merged commit f694847 into akka:master Jan 16, 2020
@ennru ennru mentioned this pull request Jan 16, 2020
Closed
@ennru
Copy link
Member

ennru commented Jan 16, 2020

Thank you for your contribution! Keep them coming.

@dl-mai
Copy link
Contributor Author

dl-mai commented Jan 16, 2020

awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:aws-s3 to-be-backported
Projects
None yet
Milestone
2.0.0-M3
Development

Successfully merging this pull request may close these issues.
3 participants
@dl-mai @lightbend-cla-validator @ennru