Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCS - Owner entityId should be optional #2176

Merged
merged 3 commits into from
Mar 4, 2020
Merged

GCS - Owner entityId should be optional #2176

merged 3 commits into from
Mar 4, 2020

Conversation

francisdb
Copy link
Contributor

Another field that should be optional
Somehow we ended up with main.scala.akka.stream... packages

References #2163

@francisdb francisdb mentioned this pull request Mar 2, 2020
Merged
@seglo
Copy link
Member

seglo commented Mar 3, 2020

@francisdb I missed the main.scala package issue from your earlier PR. @ennru fixed the problem in #2177. Can you rebase on master?

@francisdb francisdb mentioned this pull request Mar 3, 2020
Merged
@francisdb
Copy link
Contributor Author

@seglo I did not introduce those, came from #2058

@francisdb
Copy link
Contributor Author

francisdb commented Mar 3, 2020 •
edited
Loading

@seglo this is ready for review

@seglo
Copy link
Member

seglo commented Mar 4, 2020

@seglo I did not introduce those, came from #2058

My mistake.

seglo
seglo approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo changed the title GCS - another field that should be optional GCS - Owner entityId should be optional Mar 4, 2020
@seglo seglo merged commit bf4b168 into akka:master Mar 4, 2020
@francisdb francisdb deleted the fix_gcs_optional_fields branch March 4, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees
No one assigned
Labels
p:google-cloud-storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francisdb @seglo